diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2023-02-07 00:07:54 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2023-02-06 15:34:40 -0800 |
| commit | c65d18cb5259079f44c055c07bf46c13c75780c1 (patch) | |
| tree | 6d777b1acb9305083e241b8613932a0d05015ae3 /builtin/push.c | |
| parent | aa561208d9d41d757ede1fb40d3ae2c164a21f97 (diff) | |
| download | git-c65d18cb5259079f44c055c07bf46c13c75780c1.tar.gz | |
push: free_refs() the "local_refs" in set_refspecs()
Fix a memory leak that's been with us since this code was added in
ca02465b413 (push: use remote.$name.push as a refmap, 2013-12-03).
The "remote = remote_get(...)" added in the same commit would seem to
leak based only on the context here, but that function is a wrapper
for sticking the remotes we fetch into "the_repository->remote_state".
See fd3cb0501e1 (remote: move static variables into per-repository
struct, 2021-11-17) for the addition of code in repository.c that
free's the "remote" allocated here.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/push.c')
| -rw-r--r-- | builtin/push.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/builtin/push.c b/builtin/push.c index 97b35eca3a..8f7d326ab3 100644 --- a/builtin/push.c +++ b/builtin/push.c @@ -134,6 +134,7 @@ static void set_refspecs(const char **refs, int nr, const char *repo) } else refspec_append(&rs, ref); } + free_refs(local_refs); } static int push_url_of_remote(struct remote *remote, const char ***url_p) |