diff options
| author | Patrick Steinhardt <ps@pks.im> | 2023-10-31 09:16:25 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2023-11-01 12:09:00 +0900 |
| commit | 53921d5f8e63eb98cb306ea0b58f76a07bbaf36b (patch) | |
| tree | 62e12a2935256e09ea75bab6151bcefb592a6d98 /builtin/show-ref.c | |
| parent | dbabd0b023b6a65267fd57ed04ecd47ac34b5ae5 (diff) | |
| download | git-53921d5f8e63eb98cb306ea0b58f76a07bbaf36b.tar.gz | |
builtin/show-ref: fix dead code when passing patterns
When passing patterns to `git show-ref` we have some code that will
cause us to die if `verify && !quiet` is true. But because `verify`
indicates a different subcommand of git-show-ref(1) that causes us to
execute `cmd_show_ref__verify()` and not `cmd_show_ref__patterns()`, the
condition cannot ever be true.
Let's remove this dead code.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/show-ref.c')
| -rw-r--r-- | builtin/show-ref.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/builtin/show-ref.c b/builtin/show-ref.c index e55c38af47..f95418d3d1 100644 --- a/builtin/show-ref.c +++ b/builtin/show-ref.c @@ -183,11 +183,8 @@ static int cmd_show_ref__patterns(const char **patterns) } else { for_each_ref(show_ref, &show_ref_data); } - if (!found_match) { - if (verify && !quiet) - die("No match"); + if (!found_match) return 1; - } return 0; } |