diff options
| author | Patrick Steinhardt <ps@pks.im> | 2025-07-23 16:08:33 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2025-07-23 08:15:20 -0700 |
| commit | 122e38c92f19054b0da2212ed3dcbc35c221a375 (patch) | |
| tree | 01235ae99c1ed7a0c95b6220caafddf5ed3babad /builtin/submodule--helper.c | |
| parent | 5d215a7b3eb0a9a69c0cb9aa43dcae956a0aa03e (diff) | |
| download | git-122e38c92f19054b0da2212ed3dcbc35c221a375.tar.gz | |
config: drop `git_config_set_in_file()` wrapper
In 036876a1067 (config: hide functions using `the_repository` by
default, 2024-08-13) we have moved around a bunch of functions in the
config subsystem that depend on `the_repository`. Those function have
been converted into mere wrappers around their equivalent function that
takes in a repository as parameter, and the intent was that we'll
eventually remove those wrappers to make the dependency on the global
repository variable explicit at the callsite.
Follow through with that intent and remove `git_config_set_in_file()`.
All callsites are adjusted so that they use
`repo_config_set_in_file(the_repository, ...)` instead. While some
callsites might already have a repository available, this mechanical
conversion is the exact same as the current situation and thus cannot
cause any regression. Those sites should eventually be cleaned up in a
later patch series.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/submodule--helper.c')
| -rw-r--r-- | builtin/submodule--helper.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index d2ab31835b..0be737ac4f 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -1810,12 +1810,12 @@ static int clone_submodule(const struct module_clone_data *clone_data, /* setup alternateLocation and alternateErrorStrategy in the cloned submodule if needed */ repo_config_get_string(the_repository, "submodule.alternateLocation", &sm_alternate); if (sm_alternate) - git_config_set_in_file(p, "submodule.alternateLocation", - sm_alternate); + repo_config_set_in_file(the_repository, p, "submodule.alternateLocation", + sm_alternate); repo_config_get_string(the_repository, "submodule.alternateErrorStrategy", &error_strategy); if (error_strategy) - git_config_set_in_file(p, "submodule.alternateErrorStrategy", - error_strategy); + repo_config_set_in_file(the_repository, p, "submodule.alternateErrorStrategy", + error_strategy); free(sm_alternate); free(error_strategy); @@ -2522,7 +2522,7 @@ static int ensure_core_worktree(const char *path) abs_path = absolute_pathdup(path); rel_path = relative_path(abs_path, subrepo.gitdir, &sb); - git_config_set_in_file(cfg_file, "core.worktree", rel_path); + repo_config_set_in_file(the_repository, cfg_file, "core.worktree", rel_path); free(cfg_file); free(abs_path); |