diff options
| author | John Cai <johncai86@gmail.com> | 2022-01-05 23:29:32 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2022-01-10 09:39:26 -0800 |
| commit | a2585719b347b57a4fb61a4ed24301cfa3cf19a7 (patch) | |
| tree | d90692bec41e86edce64b57fb4ddf1f36792dfe0 /builtin | |
| parent | 34ae3b707146c05d27cf744e58f95a25a31b3499 (diff) | |
| download | git-a2585719b347b57a4fb61a4ed24301cfa3cf19a7.tar.gz | |
name-rev.c: use strbuf_getline instead of limited size buffer
Using a buffer limited to 2048 is unnecessarily limiting. Switch to
using a string buffer to read in stdin for annotation.
Signed-off-by: "John Cai" <johncai86@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
| -rw-r--r-- | builtin/name-rev.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/builtin/name-rev.c b/builtin/name-rev.c index 8baf5b52d0..138e3c30a2 100644 --- a/builtin/name-rev.c +++ b/builtin/name-rev.c @@ -623,14 +623,13 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix) name_tips(); if (annotate_stdin) { - char buffer[2048]; + struct strbuf sb = STRBUF_INIT; - while (!feof(stdin)) { - char *p = fgets(buffer, sizeof(buffer), stdin); - if (!p) - break; - name_rev_line(p, &data); + while (strbuf_getline(&sb, stdin) != EOF) { + strbuf_addch(&sb, '\n'); + name_rev_line(sb.buf, &data); } + strbuf_release(&sb); } else if (all) { int i, max; |