diff options
| author | Mark Levedahl <mlevedahl@gmail.com> | 2025-05-21 19:18:46 -0400 |
|---|---|---|
| committer | Mark Levedahl <mlevedahl@gmail.com> | 2025-07-22 12:32:58 -0400 |
| commit | 07714e220b7ee137f4645ec950383eaaeddf23d5 (patch) | |
| tree | 445c2e54a8854e262ab73bd0022ab1dc5781195a /lib/browser.tcl | |
| parent | 40f54f670a01b6ae4f13e0888796948ddce9104c (diff) | |
| download | git-07714e220b7ee137f4645ec950383eaaeddf23d5.tar.gz | |
git-gui: do not mix -translation binary and -encoding
git-gui has many instances of '-translation binary' and '-encoding
$SOMETHING' on the same channel. As eofchar is always null given a
prior commit, the net effect of having '-translation binary' in such
configuration is only to change how text line endings are handled.
For cases where the channel is opened to be consumed via gets, the eol
translation is irrelevant because Tcl's gets is documented to recognize
any of \n, \r, and \r\n as a line ending. So, keep only the '-encoding
$SOMETHING' configuration in these cases, making the configuration more
clear.
Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
Diffstat (limited to 'lib/browser.tcl')
| -rw-r--r-- | lib/browser.tcl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/browser.tcl b/lib/browser.tcl index f53eb952cf..fe72de025e 100644 --- a/lib/browser.tcl +++ b/lib/browser.tcl @@ -195,7 +195,7 @@ method _ls {tree_id {name {}}} { $w conf -state disabled set fd [git_read [list ls-tree -z $tree_id]] - fconfigure $fd -blocking 0 -translation binary -encoding utf-8 + fconfigure $fd -blocking 0 -encoding utf-8 fileevent $fd readable [cb _read $fd] } |