aboutsummaryrefslogtreecommitdiffstats
path: root/notes.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2023-08-08 14:50:23 -0400
committerJunio C Hamano <gitster@pobox.com>2023-08-08 16:49:10 -0700
commitcb888bb6991bb10bddedf9ddc9651ec25da6137d (patch)
tree794f68709c8c8d5fef4116f7a98e0b11191807bd /notes.c
parenta82fb66fed250e16d3010c75404503bea3f0ab61 (diff)
downloadgit-cb888bb6991bb10bddedf9ddc9651ec25da6137d.tar.gz
repack: free geometry struct
When the program is ending, we call clear_pack_geometry() to free any resources in the pack_geometry struct. But the struct itself is allocated on the heap, and leak-checkers will complain about the resulting small leak. This one was marked by Coverity as a "new" leak, though it has existed since 0fabafd0b9 (builtin/repack.c: add '--geometric' option, 2021-02-22). This might be because recent unrelated changes in the file confused it about what is new and what is not. But regardless, it is worth addressing. We can fix it easily by free-ing the struct. We'll convert our "clear" function to "free", since the allocation happens in the matching init() function (though since there is only one call to each, and the struct is local to this file, it's mostly academic). Another option would be to put the struct on the stack rather than the heap. However, this gets tricky, as we check the pointer against NULL in several places to decide whether we're in geometric mode. Signed-off-by: Jeff King <peff@peff.net> Acked-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'notes.c')
0 files changed, 0 insertions, 0 deletions
pidfs VFS treeVFS group
aboutsummaryrefslogtreecommitdiffstats
path: root/crypto/async_tx
diff options
context:
space:
mode:
authorBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>2013-07-03 15:05:06 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2013-07-03 16:07:42 -0700
commit48a9db462d99494583dad829969616ac90a8df4e (patch)
treed908a6172274a9d4d5c14752aa648086bc4721cd /crypto/async_tx
parentdcf6d294830d46b0e6901477fb4bf455281d90c8 (diff)
downloadvfs-48a9db462d99494583dad829969616ac90a8df4e.tar.gz
drivers/dma: remove unused support for MEMSET operations