diff options
| author | Patrick Steinhardt <ps@pks.im> | 2024-06-11 11:19:59 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-06-11 13:15:05 -0700 |
| commit | f87c55c2647cf3aa0e6b5e45738facb6b62fe37c (patch) | |
| tree | 1b098b88ceb32ecad516fbd68b93642a5488fd8e /object-name.h | |
| parent | 61f8bb1ec1ef6022c2e7994b8b896ab158d7070b (diff) | |
| download | git-f87c55c2647cf3aa0e6b5e45738facb6b62fe37c.tar.gz | |
object-name: free leaking object contexts
While it is documented in `struct object_context::path` that this
variable needs to be released by the caller, this fact is rather easy to
miss given that we do not ever provide a function to release the object
context. And of course, while some callers dutifully release the path,
many others don't.
Introduce a new `object_context_release()` function that releases the
path. Convert callsites that used to free the path to use that new
function and add missing calls to callsites that were leaking memory.
Refactor those callsites as required to have a single return path, only.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'object-name.h')
| -rw-r--r-- | object-name.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/object-name.h b/object-name.h index 064ddc97d1..8dba4a47a4 100644 --- a/object-name.h +++ b/object-name.h @@ -22,6 +22,8 @@ struct object_context { char *path; }; +void object_context_release(struct object_context *ctx); + /* * Return an abbreviated sha1 unique within this repository's object database. * The result will be at least `len` characters long, and will be NUL |