diff options
| author | Johannes Schindelin <johannes.schindelin@gmx.de> | 2024-11-07 08:57:52 +0100 |
|---|---|---|
| committer | Johannes Schindelin <johannes.schindelin@gmx.de> | 2024-11-26 20:24:00 +0100 |
| commit | c903985bf7e772e2d08275c1a95c8a55ab011577 (patch) | |
| tree | 485d53e1839ac405ce36fbf210855f8266bb4476 /strbuf.h | |
| parent | 83b08eb19f05710a92d565124606dcaf68bcc68b (diff) | |
| download | git-c903985bf7e772e2d08275c1a95c8a55ab011577.tar.gz | |
credential_format(): also encode <host>[:<port>]
An upcoming change wants to sanitize the credential password prompt
where a URL is displayed that may potentially come from a `.gitmodules`
file. To this end, the `credential_format()` function is employed.
To sanitize the host name (and optional port) part of the URL, we need a
new mode of the `strbuf_add_percentencode()` function because the
current mode is both too strict and too lenient: too strict because it
encodes `:`, `[` and `]` (which should be left unencoded in
`<host>:<port>` and in IPv6 addresses), and too lenient because it does
not encode invalid host name characters `/`, `_` and `~`.
So let's introduce and use a new mode specifically to encode the host
name and optional port part of a URI, leaving alpha-numerical
characters, periods, colons and brackets alone and encoding all others.
This only leads to a change of behavior for URLs that contain invalid
host names.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Diffstat (limited to 'strbuf.h')
| -rw-r--r-- | strbuf.h | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -380,6 +380,7 @@ size_t strbuf_expand_dict_cb(struct strbuf *sb, void strbuf_addbuf_percentquote(struct strbuf *dst, const struct strbuf *src); #define STRBUF_ENCODE_SLASH 1 +#define STRBUF_ENCODE_HOST_AND_PORT 2 /** * Append the contents of a string to a strbuf, percent-encoding any characters |