aboutsummaryrefslogtreecommitdiffstats
path: root/t/chainlint/nested-cuddled-subshell.expect
diff options
context:
space:
mode:
authorEric Sunshine <sunshine@sunshineco.com>2024-09-10 00:10:12 -0400
committerJunio C Hamano <gitster@pobox.com>2024-09-10 10:01:40 -0700
commite44f15ba3ee873b5df5e8e5d8cc018df288472ef (patch)
tree8718076d76999f67df5c99c70f6a211709976c45 /t/chainlint/nested-cuddled-subshell.expect
parent588ef84ecef2c9782598529ba6511d4cb72ec158 (diff)
downloadgit-e44f15ba3ee873b5df5e8e5d8cc018df288472ef.tar.gz
chainlint: make error messages self-explanatory
The annotations emitted by chainlint to indicate detected problems are overly terse, so much so that developers new to the project -- those who should most benefit from the linting -- may find them baffling. For instance, although the author of chainlint and seasoned Git developers may understand that "?!AMP?!" is an abbreviation of "ampersand" and indicates a break in the &&-chain, this may not be obvious to newcomers. The "?!LOOP?!" case is particularly serious because that terse single word does nothing to convey that the loop body should end with "|| return 1" (or "|| exit 1" in a subshell) to ensure that a failing command in the body aborts the loop immediately. Moreover, unlike &&-chaining which is ubiquitous in Git tests, the "|| return 1" idiom is relatively infrequent, thus may be harder for a newcomer to discover by consulting nearby code. Address these shortcomings by emitting human-readable messages which both explain the problem and give a strong hint about how to correct it. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/chainlint/nested-cuddled-subshell.expect')
-rw-r--r--t/chainlint/nested-cuddled-subshell.expect6
1 files changed, 3 insertions, 3 deletions
diff --git a/t/chainlint/nested-cuddled-subshell.expect b/t/chainlint/nested-cuddled-subshell.expect
index 0191c9c294..fec2c74274 100644
--- a/t/chainlint/nested-cuddled-subshell.expect
+++ b/t/chainlint/nested-cuddled-subshell.expect
@@ -5,7 +5,7 @@
6
7 (cd foo &&
8 bar
-9 ) ?!AMP?!
+9 ) ?!LINT: missing '&&'?!
10
11 (
12 cd foo &&
@@ -13,13 +13,13 @@
14
15 (
16 cd foo &&
-17 bar) ?!AMP?!
+17 bar) ?!LINT: missing '&&'?!
18
19 (cd foo &&
20 bar) &&
21
22 (cd foo &&
-23 bar) ?!AMP?!
+23 bar) ?!LINT: missing '&&'?!
24
25 foobar
26 )