diff options
| author | Jeff King <peff@peff.net> | 2018-02-14 13:08:57 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2018-02-14 10:31:10 -0800 |
| commit | a6119f82b118c7adea9ede0b3813810b06e37668 (patch) | |
| tree | abbdf5f39a46bfb2677431f72a0668af48e6e2bc /t/helper/test-hashmap.c | |
| parent | 7daa825d677dcbd40724cb146f3949b7d574e8b3 (diff) | |
| download | git-a6119f82b118c7adea9ede0b3813810b06e37668.tar.gz | |
test-hashmap: use "unsigned int" for hash storage
The hashmap API always use an unsigned value for storing
and comparing hashes. Whereas this test code uses "int".
This works out in practice since one can typically
round-trip between "int" and "unsigned int". But since this
is essentially reference code for the hashmap API, we should
model using the correct types.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/helper/test-hashmap.c')
| -rw-r--r-- | t/helper/test-hashmap.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/t/helper/test-hashmap.c b/t/helper/test-hashmap.c index 56efff36e8..9ae9281c07 100644 --- a/t/helper/test-hashmap.c +++ b/t/helper/test-hashmap.c @@ -30,7 +30,8 @@ static int test_entry_cmp(const void *cmp_data, return strcmp(e1->key, key ? key : e2->key); } -static struct test_entry *alloc_test_entry(int hash, char *key, char *value) +static struct test_entry *alloc_test_entry(unsigned int hash, + char *key, char *value) { size_t klen = strlen(key); size_t vlen = strlen(value); @@ -156,7 +157,7 @@ int cmd_main(int argc, const char **argv) /* process commands from stdin */ while (strbuf_getline(&line, stdin) != EOF) { char *cmd, *p1 = NULL, *p2 = NULL; - int hash = 0; + unsigned int hash = 0; struct test_entry *entry; /* break line into command and up to two parameters */ |