diff options
| author | Taylor Blau <me@ttaylorr.com> | 2022-08-22 15:50:35 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2022-08-22 13:04:22 -0700 |
| commit | 0b6203c4efb9eb81e0c63998aece8a3ec7ab3a16 (patch) | |
| tree | ac5a82c009e91f8b0f3e6ff894c6aa64d3b0c37a /t/lib-bitmap.sh | |
| parent | 65168c42df25c61cfbe3ab481549b250c150f1f6 (diff) | |
| download | git-0b6203c4efb9eb81e0c63998aece8a3ec7ab3a16.tar.gz | |
t/lib-bitmap.sh: avoid silencing stderr
The midx_bitmap_partial_tests() function is responsible for setting up a
state where some (but not all) packs in the repository are covered by a
MIDX (and bitmap).
This function has redirected the `git multi-pack-index write --bitmap`'s
stderr to a file "err" since its introduction back in c51f5a6437 (t5326:
test multi-pack bitmap behavior, 2021-08-31).
This was likely a stray change left over from a slightly different
version of this test, since the file "err" is never read after being
written. This leads to confusingly-missing output, especially when the
contents of stderr are important.
Resolve this confusion by avoiding silencing stderr in this case.
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/lib-bitmap.sh')
| -rw-r--r-- | t/lib-bitmap.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/lib-bitmap.sh b/t/lib-bitmap.sh index a95537e759..f595937094 100644 --- a/t/lib-bitmap.sh +++ b/t/lib-bitmap.sh @@ -440,7 +440,7 @@ midx_bitmap_partial_tests () { test_commit packed && git repack && test_commit loose && - git multi-pack-index write --bitmap 2>err && + git multi-pack-index write --bitmap && test_path_is_file $midx && test_path_is_file $midx-$(midx_checksum $objdir).bitmap ' |
