diff options
| author | Breno Leitao <leitao@debian.org> | 2025-11-27 07:30:15 -0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-11-28 20:16:57 -0800 |
| commit | e5235eb6cfe02a51256013a78f7b28779a7740d5 (patch) | |
| tree | 4653852605ea8d25c51196bcd0d4f19735051148 /mm/gup_test.c | |
| parent | 2c28ee720ad14f58eb88a97ec3efe7c5c315ea5d (diff) | |
| download | net-main.tar.gz | |
Prevent a kernel warning when netconsole setup fails on devices with
IFF_DISABLE_NETPOLL flag. The warning (at kernel/workqueue.c:4242 in
__flush_work) occurs because the cleanup path tries to cancel an
uninitialized work queue.
When __netpoll_setup() encounters a device with IFF_DISABLE_NETPOLL,
it fails early and calls skb_pool_flush() for cleanup. This function
calls cancel_work_sync(&np->refill_wq), but refill_wq hasn't been
initialized yet, triggering the warning.
Move INIT_WORK() to the beginning of __netpoll_setup(), ensuring the
work queue is properly initialized before any potential failure points.
This allows the cleanup path to safely cancel the work queue regardless
of where the setup fails.
Fixes: 248f6571fd4c5 ("netpoll: Optimize skb refilling on critical path")
Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20251127-netpoll_fix_init_work-v1-1-65c07806d736@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'mm/gup_test.c')
0 files changed, 0 insertions, 0 deletions