Skip to content

Code clean-up and fixing end-to-end tests #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 24, 2023
Merged

Code clean-up and fixing end-to-end tests #2000

merged 4 commits into from
Feb 24, 2023

Conversation

@andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Feb 23, 2023

Silenced more warnings where appropriate, fixed others, deleted dead code, re-enabled and then fixed end-to-end tests.

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-General labels Feb 23, 2023
@andyleejordan andyleejordan requested a review from a team February 23, 2023 23:39
SeeminglyScience
SeeminglyScience approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit e9310f9 into main Feb 24, 2023
@andyleejordan andyleejordan deleted the andschwa/code-review branch February 24, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees

No one assigned

Labels

Area-General Issue-Enhancement A feature request (enhancement).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andyleejordan @SeeminglyScience