ngClass broken in Angular 1.0.3?

[provegard]

I noticed some odd ngClass behavior when upgrading from Angular 1.0.1 to 1.0.3. Going back to 1.0.2 fixed the problem. The following fiddle illustrates the problem:

http://jsfiddle.net/provegard/uwwgy/14/

Since a is false initially, the text should get the "foo" class and be red. The watch kicks in immediately and changes a to true, which should remove the "foo" class from the text and thus change it back to black. This is what happens in Angular 1.0.2, but not in 1.0.3.

(In my real app, I have two Twitter Bootstrap tabs that become initially active at the same time due to this bug.)

[jtymes]

This is interesting. My suspicion is pointing to d859dce - as this commit is the most recent. Maybe @IgorMinar could weigh in on this?

This might also mean that some test cases are missing to catch a regression like this.

[beppler]

I´m having this issue too.

I reverted the code to the old one and then it starts to work again.

[andreev-artem]

I'm also having this issue.
My use case:
1.0.1 (doesn't have issue): http://jsfiddle.net/3tgCA/4/
1.0.3 (has issue): http://jsfiddle.net/3tgCA/3/
v1.0.4-661a7287 (has issue): http://jsfiddle.net/3tgCA/2/

My workaround because I need some 1.0.3 features: http://jsfiddle.net/3tgCA/5/

[groner]

The commit cebd015 adds a call to the ngClassWatchAction() after interpolation has touched the class attribute.

Because the initial interpolation event happens before the initial watch event, ngClassWatchAction() is called with a value that may change by the time the $scope.$watch($attrs.ngClass) takes effect. If that happens, the change goes undetected by the $watch() and ngClassWatchAction() doesn't know to remove the class that was added during the initial interpolation event.

Here is a simpler version of @jtymes fiddle:
http://jsfiddle.net/6DcCj/1/

With a debugger you can see that foo is true when the interpolation event fires, but is already false by the time the first watch event fires.

I think fixing this will require ng-class to track the classes it has added directly.

[munir131]

I have same issue