[Documentation] Missing data type #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the documentation of Floating Point is this example: ``` n = 0.005; // 0.005 is a floating point constant ``` This code simply won't compile and get this error : 'n' does not name a type so this Line should be : ``` const float n = 0.005; // 0.005 is a floating point constant ``` Although this error may seem trivial for some professional , but I think it seems misleading to newcomers.
per1234
previously requested changes
Feb 20, 2021
Co-authored-by: per1234 <accounts@perglass.com>
|
|
Contributor
Author
|
What happened if I close this pull request after all commiters have signed CLA ? |
Collaborator
|
@mohammedhemed77 if you close the pull request it won't ever be merged. |
per1234
approved these changes
Aug 13, 2022
Collaborator
per1234
left a comment
There was a problem hiding this comment.
Thanks @mohammedhemed77!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the documentation of Floating Point I noticed this example:
This code simply won't compile and get this error :
'n' does not name a type
so this Line should be :
Although this error may seem trivial for some professionals , but I think it seems misleading to newcomers.