[MKC-1311] [MKC-1312] Add compatible hardware to Mouse & Keyboard #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlsoderby
reviewed
Nov 20, 2023
karlsoderby
reviewed
Nov 20, 2023
karlsoderby
reviewed
Nov 20, 2023
karlsoderby
requested changes
Nov 20, 2023
Collaborator
karlsoderby
left a comment
There was a problem hiding this comment.
Looks good! Couple of suggestions before we can merge!
karlsoderby
approved these changes
Nov 20, 2023
Collaborator
|
@Hannes7eicher @karlsoderby really?????? What makes you think pins are relevant to the subject of HID? What sort of verification did you do for the list of boards? These libraries do not support the Nano ESP32 and GIGA R1 WiFi, which you would have learned by simply attempting to compile any sketch that uses either library for these boards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a table of compatible hardware for the keyboard and mouse language reference.