MNT: drop deprecated License classifier, update related metadata (PEP 639) #57
Conversation
|
CI was disabled. Close/reopen to run it. |
|
You have to drop Python 3.8 here as well. FYI. |
|
thanks, I missed the notification ! |
|
Ooof looks like some technical debts need fixing also. |
|
Only some jobs are failing. For the older versions, might want to be more conservative in bumping test matrix. |
|
yeah, it might take a couple iterations |
5268326 to
1a4786f
Compare
41f9950 to
e5db568
Compare
|
should be good now |
| [tox] | ||
| envlist = | ||
| py{38,39,310,311,312}-test{,-pytestoldest,-pytest52,-pytest53,-pytest60,-pytest61,-pytest62,-pytest70,-pytest71,-pytest72,-pytest73,-pytest74,-devdeps} | ||
| py{39,310,311,312,313,314}-test{,-pytestoldest,-pytest52,-pytest53,-pytest60,-pytest61,-pytest62,-pytest70,-pytest71,-pytest72,-pytest73,-pytest74,-devdeps} |
There was a problem hiding this comment.
Did you give up on py314? I see it added here but no longer used.
There was a problem hiding this comment.
I tried to use it but tables doesn't have wheels for it yet so any env I did try just failed to install.
There was a problem hiding this comment.
Gotcha. We can address that via follow up issue.
There was a problem hiding this comment.
or just wait for tables to catch up
.github/workflows/ci_workflows.yml
Outdated
| with: | ||
| test_extras: test | ||
| test_command: pytest $GITHUB_WORKSPACE/tests; pytest --arraydiff $GITHUB_WORKSPACE/tests | ||
| python-version: '3.13' |
There was a problem hiding this comment.
Do we want to publish wheel with oldest supported Python?
There was a problem hiding this comment.
As you wish, I don't know that it matters much since we can't get to this point without passing the build matrix first
There was a problem hiding this comment.
Me neither. Probably no difference but better be safe than sorry.
There was a problem hiding this comment.
sounds reasonable to me
e5db568 to
6090174
Compare
This comment was marked as resolved.
This comment was marked as resolved.
6090174 to
34ee95e
Compare
|
For completeness, I opened #58 as follow-up issue. |
No description provided.