Connection string - passwords with `:` or `?` are not encoded

[Idlesome]

When I have a connection string with special characters such as:

postgresql://username:pass?word:3$@my-database-host.com:5432/dbname

I get this error:

TypeError: Cannot read properties of undefined (reading 'searchParams')

This is because the ? is determined to be the end of the URL (it's expecting something like ?sslmode=require at the end of the string).

Essentially the URL has not been encoded correctly. To resolve this, you can URL encode your password - so this will work:

postgresql://username:pass%3Fword%3A3%24@my-database-host.com:5432/dbname

However, if you're passing your connection string as a secret without having encoded it ahead of time, you'd have to manually extract the password and apply this encoding.

I'm posting this mainly to help others who may run into issue, especially since it's not obvious from the error what the problem is - but perhaps we could resolve this by automatically encoding the password, or otherwise throwing an "invalid connection string" error if the password is not encoded properly?

I may be wrong, but I think Drizzle's pg client seems to work "out of the box" with this type of connection string.

[charmander]

Yes, an invalid connection string should throw an error with a descriptive message. (We definitely shouldn’t try to guess at the intended meaning of bad values.)

[charmander]

But I can’t reproduce this error, or see a path in pg-connection-string where result could be undefined at the time result.searchParams is accessed. Please always provide the standard information when making bug reports: environment (especially platform and package versions), full stack trace, reproducer, etc.

let client = new pg.Client('postgresql://username:pass?word:3$@my-database-host.com:5432/dbname')
// Uncaught TypeError: Invalid URL