Skip to content

chore: add groups to integration test #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

chore: add groups to integration test #34

merged 1 commit into from
Jul 23, 2024

Conversation

@ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Jul 17, 2024 •
edited
Loading

I've decided these should go in the existing user-test integration test case since it's best to test the groups with users in them.

This was referenced Jul 17, 2024
Merged
Merged
@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Jul 17, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson mentioned this pull request Jul 17, 2024
Merged
@ethanndickson ethanndickson force-pushed the 07-17-feat_add_coderd_organization_data_source branch from f95a970 to 695f2f4 Compare July 17, 2024 07:57
@ethanndickson ethanndickson force-pushed the 07-17-chore_add_groups_to_integration_test branch from 250ad4e to e97e71c Compare July 17, 2024 07:57
@ethanndickson ethanndickson force-pushed the 07-17-feat_add_coderd_organization_data_source branch from 695f2f4 to 7dc20eb Compare July 17, 2024 08:12
@ethanndickson ethanndickson force-pushed the 07-17-chore_add_groups_to_integration_test branch from e97e71c to 40c3e02 Compare July 17, 2024 08:12
@ethanndickson ethanndickson marked this pull request as ready for review July 17, 2024 08:14
ethanndickson
ethanndickson commented Jul 17, 2024
View reviewed changes
integration/user-test/main.tf

data "coderd_organization" "default" {
is_default = true
}
Copy link
Member Author

@ethanndickson ethanndickson Jul 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally sure on this from a UX perspective - but we can't use name="default" because the first organisation, whilst it can be retrieved using the name default, actually has the name first-organization.

Copy link
Member Author

@ethanndickson ethanndickson Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and I'm 90% sure Terraform is always going to spit the dummy if we just replaced the given name?

@ethanndickson ethanndickson mentioned this pull request Jul 18, 2024
Merged
3 tasks
@ethanndickson ethanndickson force-pushed the 07-17-feat_add_coderd_organization_data_source branch from 7dc20eb to 24a0fe9 Compare July 18, 2024 13:26
@ethanndickson ethanndickson force-pushed the 07-17-chore_add_groups_to_integration_test branch from 40c3e02 to c0065c3 Compare July 18, 2024 13:26
@ethanndickson ethanndickson force-pushed the 07-17-feat_add_coderd_organization_data_source branch from 24a0fe9 to 962336f Compare July 18, 2024 13:50
@ethanndickson ethanndickson force-pushed the 07-17-chore_add_groups_to_integration_test branch from c0065c3 to 3e749a6 Compare July 18, 2024 13:50
@ethanndickson ethanndickson force-pushed the 07-17-feat_add_coderd_organization_data_source branch from 962336f to adb48de Compare July 19, 2024 12:40
@ethanndickson ethanndickson force-pushed the 07-17-chore_add_groups_to_integration_test branch from 3e749a6 to 39670c5 Compare July 19, 2024 12:40
@ethanndickson ethanndickson force-pushed the 07-17-feat_add_coderd_organization_data_source branch from adb48de to e313323 Compare July 19, 2024 12:42
@ethanndickson ethanndickson force-pushed the 07-17-chore_add_groups_to_integration_test branch from 39670c5 to 2fca026 Compare July 19, 2024 12:43
@ethanndickson ethanndickson force-pushed the 07-17-feat_add_coderd_organization_data_source branch from e313323 to 63f4357 Compare July 19, 2024 12:44
@ethanndickson ethanndickson force-pushed the 07-17-chore_add_groups_to_integration_test branch from 2fca026 to 8222503 Compare July 19, 2024 12:44
@ethanndickson ethanndickson force-pushed the 07-17-feat_add_coderd_organization_data_source branch from 63f4357 to ae0d572 Compare July 19, 2024 12:45
@ethanndickson ethanndickson force-pushed the 07-17-chore_add_groups_to_integration_test branch from 8222503 to 2632693 Compare July 19, 2024 12:45
@ethanndickson ethanndickson force-pushed the 07-17-feat_add_coderd_organization_data_source branch from ae0d572 to aa86273 Compare July 22, 2024 12:59
@ethanndickson ethanndickson force-pushed the 07-17-chore_add_groups_to_integration_test branch 2 times, most recently from cae8c17 to 92ecb54 Compare July 22, 2024 13:02
@ethanndickson ethanndickson force-pushed the 07-17-chore_add_groups_to_integration_test branch from 92ecb54 to b35dec9 Compare July 22, 2024 13:02
@ethanndickson ethanndickson changed the base branch from 07-17-feat_add_coderd_organization_data_source to main July 22, 2024 13:02
@ethanndickson ethanndickson merged commit 75f030f into main Jul 23, 2024
This was referenced Jul 25, 2024
Merged
Merged
@deansheather deansheather deleted the 07-17-chore_add_groups_to_integration_test branch July 26, 2024 07:14
@ethanndickson ethanndickson mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deansheather deansheather deansheather approved these changes

@coadler coadler Awaiting requested review from coadler

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethanndickson @deansheather