Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Jul 26, 2020

Types of changes

  • Bug fix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe)

Description

initial ".pre-commit-config.yaml" with cz hook through cz init

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Steps to Test This Pull Request

  1. Run cz init. Choose "Y" for "Do you want to install pre-commit hook?"

Expected behavior

  1. A ".pre-commit-config.yaml" file with cz hook should be created

Related Issue

#113

Additional context

@Lee-W Lee-W requested a review from woile July 26, 2020 15:33
@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

❗ No coverage uploaded for pull request base (next@7638381). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #236   +/-   ##
=======================================
  Coverage        ?   96.59%           
=======================================
  Files           ?       33           
  Lines           ?      910           
  Branches        ?        0           
=======================================
  Hits            ?      879           
  Misses          ?       31           
  Partials        ?        0           
Flag Coverage Δ
#unittests 96.59% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7638381...c619c87. Read the comment docs.

@woile woile merged commit ff45e19 into next Jul 26, 2020
@woile woile deleted the add-pre-commit-in-init-cmd branch July 26, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants