This repository was archived by the owner on Jan 10, 2024. It is now read-only.
Replaced escape(soql) and escape(sosl) #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to support umlaut and other European charaters Replaced with encodeURIComponent(soql) and encodeURIComponent(sosl)
Contributor
|
Looks good - thanks! |
metadaddy
pushed a commit
that referenced
this pull request
Jul 10, 2015
Replaced escape(soql) and escape(sosl)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to support umlaut and other European charaters
Replaced with encodeURIComponent(soql) and
encodeURIComponent(sosl)
When trying to soql or sosl search for account names and other field containing umlauts and special characters, it fails to correctly encode using escape().
As far as I know, escape() is deprecated, and encodeURIComponent() is the recommended replacement as well.