Skip to content

Conversation

@sliverc
Copy link
Member

@sliverc sliverc commented Jun 13, 2018

No code changes needed.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added (no code changes)
  • documentation updated
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS

@sliverc sliverc requested a review from mblayman June 13, 2018 14:59
@codecov-io
Copy link

codecov-io commented Jun 13, 2018

Codecov Report

Merging #441 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #441   +/-   ##
======================================
  Coverage    92.6%   92.6%           
======================================
  Files          54      54           
  Lines        2812    2812           
======================================
  Hits         2604    2604           
  Misses        208     208

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6a72c...b5a1fd1. Read the comment docs.

Copy link
Collaborator

@mblayman mblayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 There is also a place in the getting started docs that references DRF that should probably be updated too. Otherwise, this looks good to me.

@sliverc
Copy link
Member Author

sliverc commented Jun 14, 2018

Thanks. Also added version to getting started guide. Merging.

@sliverc sliverc merged commit 028f191 into django-json-api:master Jun 14, 2018
@sliverc sliverc deleted the drf38 branch June 14, 2018 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants