Add MASK_URL for url sanitization #1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.11.4 added more strict URL checking when calling `urllib.parse.urlparse`. This caused the url sanitization to fail when the url contained brackets, as with `[REDACTED]` when redacting passwords in URLs
beniwohli
approved these changes
Jun 12, 2023
Contributor
beniwohli
left a comment
There was a problem hiding this comment.
Good catch and nice fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.11.4 added more strict URL checking when calling
urllib.parse.urlsplit. This caused the url sanitization to fail when the url contained brackets, as with[REDACTED]when redacting passwords in URLs.I've added a new
constants.MASK_URLfor use in URL masking, without the square brackets.