Skip to content

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Apr 10, 2023

This PR does a few things:

  1. Removes versioned copies of the CLI docs.
  2. Moves the CLI content from the docs directory up a level.
  3. Updates docusaurus.config.js to reference the CLI given this new structure.
  4. Updates the crowdin.yml file to allow the CLI documentation (minus the auto generated commands) to be translated.

Note 1: The Guide will have several broken links for now. The Guide is versioned and is trying to referenced versioned pages of The CLI. Once Guide is un-versioned this should be resolved.
Note 2: The version dropdown has not been moved yet. This will be moved in a future PR.

@vercel
Copy link

vercel bot commented Apr 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2023 5:24pm

@liamdebeasi liamdebeasi changed the title Unversion cli refactor(docs): unversion the CLI portion of the docs Apr 10, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review April 10, 2023 15:51
@liamdebeasi liamdebeasi requested a review from a team April 10, 2023 15:51
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that if you visit any of the CLI pages, and then use the version dropdown to switch to an earlier version of Ionic, you get booted to the docs homepage. I assume that'll be fixed/avoided once the version dropdown is moved in a future PR?

@liamdebeasi
Copy link
Contributor Author

Yeah I plan on moving the version selector to only show up on the Components/API pages.

@liamdebeasi liamdebeasi merged commit 7f336f8 into unversion Apr 11, 2023
@liamdebeasi liamdebeasi deleted the unversion-cli branch April 11, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants