Skip to content

Sync #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pasor1 merged 36 commits into from
Jun 21, 2021
Merged

Sync #328

pasor1 merged 36 commits into from
Jun 21, 2021

Conversation

@pasor1
Copy link
Member

@pasor1 pasor1 commented Jun 21, 2021

No description provided.

joaquinelio and others added 30 commits March 28, 2021 00:08
@joaquinelio
transpiler def
f723253
@ZYinMD
Update article.md
3d88d33
@joaquinelio
"inserts into" instead of "appends to"
2dce19e
@joaquinelio
Update article.md
497ca99
@iliakan
Merge pull request #2633 from joaquinelio/patch-4
9680c67 
"inserts into" instead of "appends to"
@NNboru
Unnecessary escape characters in cookie.js
cd466c5 
Removed unnecessary escape characters from regex in "getCookie function in cookie.js" - 
. ( ) [ / +
The above characters don't need escaping.
@joaquinelio
Update article.md
8c910b4
@joaquinelio
Update article.md
8cf2d51
@joaquinelio
Update article.md
0c41930
@joaquinelio
Update article.md
263f57e
@iliakan
Merge pull request #2555 from joaquinelio/patch-6
492f506 
transpiler def
@iliakan
minor fixes
a6dfbb7
@iliakan
Merge pull request #2636 from NNboru/patch-1
29f0121 
Unnecessary escape characters in cookie.js
@ZYinMD
update one code comment in 1-js/09-classes/04-private-protected-prope…
de36d0d 
…rties-methods

It looks like code was changed some time ago, but comments didn't change accordingly.
@joaquinelio
Maybe. "accessors" link
c45e78f
@ZYinMD
slightly improve clarity on Promise.all()
d43bdd2
@iliakan
Merge pull request #2627 from ZYinMD/patch-5
e49bc3b 
minor edit to 1-js/05-data-types/02-number/
@iliakan
closes #2641
e877796
@iliakan
minor fixes
ff53f06
@iliakan
minor fixes
cf82cc3
@iliakan
minor fixes
85282ef
@iliakan
minor fixes
a40ca9a
@iliakan
minor fixes
54347b7
@iliakan
minor fixes
df6e5a4
@iliakan
minor fixes
e769408
@iliakan
minor fixes
de81cb4
@iliakan
minor fixes
7dacfd4
@iliakan
minor fixes
3661393
@iliakan
Merge pull request #2640 from ZYinMD/patch-17
1b16f9d 
slightly improve clarity of Promise.all()
@iliakan
Merge pull request #2639 from joaquinelio/patch-4
6f14c39 
Maybe. "Accessors" link
@javascript-translate-bot javascript-translate-bot requested a review from a team June 21, 2021 08:14
@CLAassistant
Copy link

CLAassistant commented Jun 21, 2021 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 6 committers have signed the CLA.

✅ joaquinelio
✅ iliakan
✅ pasor1
❌ Yoona8
❌ ZYinMD
❌ NNboru
You have signed the CLA already but the status is still pending? Let us recheck it.

@pasor1 pasor1 merged commit 6e94b21 into javascript-tutorial:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@pasor1 @CLAassistant @javascript-translate-bot @joaquinelio @ZYinMD @iliakan @NNboru @Yoona8