Skip to content

The "switch" statement #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 25, 2023
Merged

The "switch" statement #108

merged 16 commits into from
Jun 25, 2023

Conversation

@odsantos
Copy link
Contributor

@odsantos odsantos commented Feb 20, 2020

Add switch directory files translation.

@odsantos odsantos self-assigned this Feb 20, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team February 20, 2020 21:46
@javascript-translate-bot
Copy link

javascript-translate-bot commented Feb 20, 2020

Error: the article already translated in the Progress Issue #1 ⁉️

@odsantos odsantos mentioned this pull request Mar 17, 2020
Closed
odsantos added 4 commits March 17, 2020 23:13
@odsantos
Update article.md
89ead44 
Add corrections to translation.
@odsantos
Update solution.md
87215a5 
Add corrections to translation.
@odsantos
Update task.md
988ea12 
Add corrections to translation.
@odsantos
Update solution.md
c8e18ce
@iliakan iliakan mentioned this pull request Mar 19, 2020
Open
@odsantos
Copy link
Contributor Author

odsantos commented Mar 19, 2020

The lesson had a former #57 PR merged by me.

@wnleao
Copy link
Contributor

wnleao commented May 9, 2020

Hey, @odsantos ! Could you update your commits with respect to the english version? https://github.com/javascript-tutorial/en.javascript.info/tree/master/1-js/02-first-steps/14-switch

@CLAassistant
Copy link

CLAassistant commented May 15, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@odsantos
Copy link
Contributor Author

odsantos commented Aug 5, 2020

Hey, @odsantos ! Could you update your commits with respect to the english version? https://github.com/javascript-tutorial/en.javascript.info/tree/master/1-js/02-first-steps/14-switch

Hi @kiniggit, I believe the files are now updated.
Thank you.

jonnathan-ls
jonnathan-ls requested changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@jonnathan-ls jonnathan-ls left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odsantos ... my review!

@javascript-translate-bot
Copy link

javascript-translate-bot commented Oct 14, 2022

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@odsantos
Copy link
Contributor Author

odsantos commented Dec 4, 2022

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team December 4, 2022 22:44
odsantos
odsantos commented Dec 4, 2022
View reviewed changes
Copy link
Contributor Author

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address @jonnathan-ls requested changes.

jonnathan-ls
jonnathan-ls approved these changes Jun 25, 2023
View reviewed changes
@jonnathan-ls jonnathan-ls merged commit 6a52867 into javascript-tutorial:master Jun 25, 2023
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jun 25, 2023

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonnathan-ls jonnathan-ls jonnathan-ls approved these changes

+1 more reviewer

@exploitmik exploitmik exploitmik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@odsantos odsantos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@odsantos @javascript-translate-bot @wnleao @CLAassistant @exploitmik @jonnathan-ls