update to use latest prerelease 4.0 SDK API #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2021
zurab-darkly
approved these changes
Aug 6, 2021
zurab-darkly
left a comment
There was a problem hiding this comment.
👍 confirmed tests do pass locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts for the changes made in https://github.com/launchdarkly/php-server-sdk-private/pull/66. It also switches to using the prerelease 4.0.x version of the SDK; previously we were cheating by using 3.9, but that won't work now that these internal classes have moved.
The CI for this project won't pass until we have released the 4.0 SDK and changed composer.json to remove the reference to the private SDK repo, because this project has the standard CircleCI deploy key that's for its own repo only. However, it will pass when we pull this shared code into the Git subtree in the various database integration packages (which I've already done, in PR branches in those repos)... because those have already been set up with deploy keys to access the prerelease SDK. This will be a non-issue after the release.
If you want to verify that the tests here do pass, just clone the code locally and run
composer install && vendor/bin/phpunit.