GSoC'21 Mid-Term Progress: Aitik Gupta #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@story645 do you want to check this before me merging? |
story645
reviewed
Jul 2, 2021
Member
story645
left a comment
There was a problem hiding this comment.
Great post, like the balance of detail and whole picture. Couple of nits.
story645
approved these changes
Jul 4, 2021
Contributor
Author
|
Mind if I bump this up? |
Member
|
Sure, let me know when ready to publish |
Contributor
Author
|
I think it's ready to publish, since @story645 has approved after I worked on her review. |
Member
|
Yeah sorry only reason I didn't merge is cause every time I try, something usually goes wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're almost halfway through!