Skip to content

Conversation

@mdboom
Copy link
Member

@mdboom mdboom commented Jul 29, 2011

Adds an rcParam "axes.formatter.use_locale", that when true will use the current locale to format tick labels. For example, in the fr_FR locale, the ',' will be used as a decimal separator.

…the current locale to format tick labels. For example, in the fr_FR locale, the ',' will be used as a decimal separator.
@mdboom
Copy link
Member Author

mdboom commented Aug 1, 2011

NOTE: Don't merge. Original poster reported on mailing list that this breaks 3D plots. I can't reproduce, but am trying to get to the bottom of it.

@mdboom
Copy link
Member Author

mdboom commented Aug 1, 2011

TESTING NOTE: This is difficult feature to test. One could imagine setting the locale to "fr_FR" for example, and then looking for commas, but that will only work if the French locale is installed on the machine running the test. Ubuntu, for example, only installs locales for languages selected in the installer. MS Windows (I believe) has similar issues.

…ect value for preferred encoding. Printing localized dates is not possible without this.
@WeatherGod
Copy link
Member

I wouldn't be surprised if it did break mplot3d code as it does the tick labels is a poor way. If I could have some sort of script that reproduce it for someone who does not use other locales, I could take a look.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to have this print statement here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thanks.

@WeatherGod
Copy link
Member

Come to think of it, it might be highly dependent upon exactly what patches the user and/or you have for testing. I did make some changes to mplot3d/axes3d.py recently that dealt with the formatting of the coordinates in the lower-right corner of the figure window. The changes should have gotten rid of some wonky behavior and made it behave much more like the rest of matplotlib.

@mdboom
Copy link
Member Author

mdboom commented Aug 17, 2011

I'm starting to be convinced that this has no effect on the 3D code as the original poster suggested. I think this is probably safe to merge, but will leave it open for comments.

@WeatherGod
Copy link
Member

Agreed. If it does have an impact, then it is more likely that we would be
able to have a better feedback on the issue (tracebacks and such). Go ahead
and merge this.

@efiring efiring merged commit ab8283f into matplotlib:master Aug 19, 2011
@mdboom mdboom deleted the locale_formatting branch March 3, 2015 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants