Irrigation - goGetValveTimes() update + Manual button operation fix #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goGetValveTimes functions was sending 3 requests to the controller without pause or waiting for response - thus the receive code was rejecting the replies and the sender was NACKing some sends. This update replaces the goGetValveTimes function with a timed receiver that works 100% of the time. Other changes to make the VALVE_TIMES_RELOAD a variable with comments at the top and adjustments to the Setup to call this updated method.
This mod fixes an issue where the status of the system was NOT sent to the controller on a manual button operation due to the lastState being updated to a new state in the displayMenu. The displayMenu was called just before the lastState = state; line which meant the state was never iterated with the changed value from the displayMenu. The relays would click but the status was never transmitted. Also added some minor 50ms delays on the status updates to reduce radio saturation. Changed some DEBUG messages to show the Zone names on time change and made the VAR_3 display consistent with other VAR debug displays.
Contributor
Author
|
Sorry I closed this accidentally but I can see that the goGetValveTime method may now loop if the controller goes down - I will address this and update again but the manual button bug resolution is very solid and makes the project work as expected. Having said this about the goGetValveTimes it will not really matter if this loops around on a wait as the unit will not operate without backend controller connection anyway, the display will just have the water drop icon visible until connection is made back to the controller. I did just change the delay times to 50 instead of 500 and it works better/faster. |
Reduced the delay in the method improves performance in case you are using this node as a relay or have other sensors connected.
Final updates to goGetValveTimes() added timeouts for the controller variables system, reduced code to use new allVars int array declared at the top, reduces code base to smaller than the original 2.0 code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update replaces the goGetValveTimes function with a timed receiver that works 100% of the time. Other changes to make the VALVE_TIMES_RELOAD a variable with comments at the top and adjustments to the Setup to call this updated method.
Fix issue where the status of the system was NOT sent to the controller on a manual button operation due to the lastState being updated to a new state in the displayMenu. The displayMenu was called just before the lastState = state; line which meant the state was never iterated with the changed value from the displayMenu. The relays would click but the status was never transmitted.
Also added some minor 50ms delays on the status updates to reduce radio saturation. Changed some DEBUG messages to show the Zone names on time change and made the VAR_3 display consistent with other VAR debug displays.