Skip to content

Conversation

@sinhrks
Copy link
Member

@sinhrks sinhrks commented Jul 16, 2016

Do not use area legend workaround if mpl >= 1.5.0 is available. Legends are now displayed properly if mpl >= 1.5.0.
#9161:

df = pd.DataFrame(np.random.rand(10, 3))
df.plot(kind='area', subplots=True, sharex=True, legend=True)

index
#13544:

df = pd.DataFrame(np.random.rand(20, 5), columns=['A', 'B', 'C', 'D', 'E'])
df.plot(kind='area', linewidth=0.1).legend(loc="center left", bbox_to_anchor=(1.02, 0.5))

index2

@sinhrks sinhrks added Visualization plotting Compat pandas objects compatability with Numpy or Python functions labels Jul 16, 2016
@sinhrks sinhrks added this to the 0.19.0 milestone Jul 16, 2016
@codecov-io
Copy link

codecov-io commented Jul 16, 2016

Current coverage is 85.30% (diff: 72.72%)

Merging #13680 into master will decrease coverage by <.01%

@@             master     #13680   diff @@
==========================================
  Files           139        139          
  Lines         50143      50146     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          42776      42776          
- Misses         7367       7370     +3   
  Partials          0          0          

Powered by Codecov. Last update 142c796...968aecc

@jorisvandenbossche
Copy link
Member

Looks good to me. @TomAugspurger Can you have a look?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this worth warning over? Seems similar to the subplots=True, axes=... case, which we do warn about.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see below you were moving that from below. Never mind then.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jul 23, 2016

Just the one question, but not really relevant to this PR. +1

Oh, might want a whatsnew entry.

@jreback
Copy link
Contributor

jreback commented Aug 9, 2016

@TomAugspurger status of this?

@TomAugspurger TomAugspurger merged commit 1c7d194 into pandas-dev:master Aug 10, 2016
@sinhrks sinhrks deleted the plot_area_legend branch August 10, 2016 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compat pandas objects compatability with Numpy or Python functions Visualization plotting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plot area legend rendered incorrectly when moved out of the plot area plots are causing my unit tests to fail

5 participants