PDOException::getCode() returns string instead of int

[8ctopus]

Description

The following code:

<?php

declare(strict_types=1);

use PDO;
use PDOException;

try {
    $database = new PDO('sqlite::memory:', null, null, null);

    $query = $database->prepare('SELECT * FROM test2');
    $query->execute();
} catch (PDOException $exception) {
    $code = $exception->getCode();
    echo gettype($code);
}

Resulted in this output:

string

But I expected this output instead:

int

https://www.php.net/manual/en/class.pdoexception

final public Exception::getCode(): int

PHP Version

php 8.2.10

Operating System

alpine 3.18.3

[8ctopus]

links to #9529

[8ctopus]

I would like to understand if the documentation should be updated from int to string or int|string or if this is a bug that should be addressed.

[SakiTakamachi]

https://www.php.net/manual/en/exception.getcode.php#refsect1-exception.getcode-returnvalues

It may be very confusing, but getCode() of the Exception class returns an int.
getCode of PDOException returns string.

The description on the PDOException page appears to be about the methods of the Exception it inherits from.
It is true that the return value of the inherited source is an int, but I have to say that it is very difficult to understand.

[8ctopus]

@SakiTakamachi Thank you for your explanation which made it clear.

Should I submit a PR to update the documentation?

https://github.com/php/doc-en/blob/master/reference/pdo/pdoexception.xml

[SakiTakamachi]

@8ctopus

To begin with, it seems strange that the signature would change even though it is being extended, but I think we need more time to discuss this.

For now, I think it's best for you to suggest corrections to the documentation first.

Thank you.

[alecpl]

While on documentation, this is also confusing:

/* Properties */
protected int|string $code;
...
/* Inherited properties */
...
protected int $code;

[Girgias]

This is a known issue and has been the case since forever.

This will need an RFC to amend the API for PDOExceptions.

[8ctopus]

I cannot do the RFC as I do not feel qualified.

[Girgias]

Duplicate of #9529