Skip to content

Conversation

@guoxiao
Copy link

@guoxiao guoxiao commented Feb 1, 2015

No description provided.

@smalyshev
Copy link
Contributor

How the build fails and on which OS X version/compiler? I build on OS X almost every day and didn't have any problem.

@smalyshev smalyshev added the Bug label Feb 2, 2015
@laruence
Copy link
Member

laruence commented Feb 3, 2015

what is the error? which compiler do you use?

@guoxiao
Copy link
Author

guoxiao commented Feb 3, 2015

@laruence sorry I forgot to provide building details.
Just build php with --enable-dtrace, and it reports error as following:

php-src/Zend/zend.c:1064:3: error: 'va_start' used in function with fixed args
  __builtin_va_start(args, format);

OSX version: 10.10.2
Compiler version: clang
Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn)
Target: x86_64-apple-darwin14.1.0
Thread model: posix

@guoxiao guoxiao changed the title Fix build in OSX Fix build in OSX with --enable-dtrace Feb 3, 2015
@laruence
Copy link
Member

laruence commented Feb 7, 2015

@guoxiao I've got a slight different fix, and committed, thanks for the reporting & PR.

@php-pulls
Copy link

Comment on behalf of laruence at php.net:

closed

@php-pulls php-pulls closed this Feb 7, 2015
dstogov added a commit to dstogov/php-src that referenced this pull request Feb 10, 2015
* master: (74 commits)
  Shut up, my lovely compiler; I do not like your warnings
  Márcio Almada 	remove dead tokens: T_CHARACTER, T_BAD_CHARACTER.
  fix detection of mbstate_t with clang
  Add missing NEWS and UPGRADING for bug #68938
  moved the part of the test into an appropriate place
  Removed unused REGISTER_PDO_CONST_LONG
  Fix another invalid free of CG(interned_empty_string)
  add tests for #68996
  Fixed #68790 (Missing return)
  Fixed #68790 (Missing return)
  Update README.TESTING
  Small Spacing adjustments for better reading
  added ODBCVER to phpinfo()
  added PCRE JIT availability info to phpinfo()
  Improve tests for bug 67436
  Fixed issue php#1041 (Fix build in OSX with --enable-dtrace)
  fix setting default ODBCVER value in config.w32
  updated NEWS
  updated NEWS
  Fixed bug #68964 Allowed memory size exhausted with odbc_exec
  ...
dstogov added a commit to dstogov/php-src that referenced this pull request Feb 10, 2015
* master: (371 commits)
  Shut up, my lovely compiler; I do not like your warnings
  Márcio Almada 	remove dead tokens: T_CHARACTER, T_BAD_CHARACTER.
  fix detection of mbstate_t with clang
  Add missing NEWS and UPGRADING for bug #68938
  moved the part of the test into an appropriate place
  Removed unused REGISTER_PDO_CONST_LONG
  Fix another invalid free of CG(interned_empty_string)
  add tests for #68996
  Fixed #68790 (Missing return)
  Fixed #68790 (Missing return)
  Update README.TESTING
  Small Spacing adjustments for better reading
  added ODBCVER to phpinfo()
  added PCRE JIT availability info to phpinfo()
  Improve tests for bug 67436
  Fixed issue php#1041 (Fix build in OSX with --enable-dtrace)
  fix setting default ODBCVER value in config.w32
  updated NEWS
  updated NEWS
  Fixed bug #68964 Allowed memory size exhausted with odbc_exec
  ...

Conflicts:
	ext/session/session.c
dstogov added a commit to zendtech/php-src that referenced this pull request Feb 27, 2015
* master: (373 commits)
  Shut up, my lovely compiler; I do not like your warnings
  Márcio Almada 	remove dead tokens: T_CHARACTER, T_BAD_CHARACTER.
  fix detection of mbstate_t with clang
  Add missing NEWS and UPGRADING for bug #68938
  moved the part of the test into an appropriate place
  Removed unused REGISTER_PDO_CONST_LONG
  Fix another invalid free of CG(interned_empty_string)
  add tests for #68996
  Fixed #68790 (Missing return)
  Fixed #68790 (Missing return)
  Update README.TESTING
  Small Spacing adjustments for better reading
  added ODBCVER to phpinfo()
  added PCRE JIT availability info to phpinfo()
  Improve tests for bug 67436
  Fixed issue php#1041 (Fix build in OSX with --enable-dtrace)
  fix setting default ODBCVER value in config.w32
  updated NEWS
  updated NEWS
  Fixed bug #68964 Allowed memory size exhausted with odbc_exec
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants