Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

closes #2176

in the process refactors Filters.name to be a property. this makes it a bit more flexible (alloing it to be non-static) and also make XOR Filters have a proper name

@Bibo-Joshi Bibo-Joshi requested a review from Poolitzer November 4, 2020 17:28
@Bibo-Joshi Bibo-Joshi added enhancement 🛠 refactor change type: refactor labels Nov 4, 2020
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	telegram/ext/filters.py
@Bibo-Joshi Bibo-Joshi merged commit d1438a9 into master Nov 7, 2020
@Bibo-Joshi Bibo-Joshi deleted the xor-filters branch November 7, 2020 07:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 enhancement pr description: enhancement 🛠 refactor change type: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] XOR for filters

3 participants