Speed up constant database creation #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to sync to disk every time a record is added, because in a constant database records are only added at database creation time, and the database is created in a temp file before being moved to the final file. A sync is only needed once after all records have been added. Further force-output is not a sync because it returns before completion. finish-output is a sync (to the extent that Common Lisp offers one). With this patch, my systems.cdb gets created in 0.6 seconds instead of 44 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to sync to disk every time a record is added, because in a constant database records are only added at database creation time, and the database is created in a temp file before being moved to the final file. A sync is only needed once after all records have been added. Further
force-outputis not a sync because it returns before completion.finish-outputis a sync (to the extent that Common Lisp offers one).With this patch, my systems.cdb gets created in 0.6 seconds instead of 44 seconds.