-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: major exercise content and workflows refresh #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the project description and estimated completion time.
chriswblake
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really liked this exercise. No required changes, just ideas for improvements/tweaks.
I do however feel 1 thing is lacking that myself and many other people will probably wish was shown: inputs
Maybe you can tweak the exercise to let them "search" for a joke and the default is random if no input value is provided. Or just provide N jokes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request modernizes the "Write JavaScript Actions" exercise by restructuring it to use GitHub Codespaces and issue-based workflow automation. The exercise now teaches users to build a Dad Jokes action at the repository root using modern bundling practices with @vercel/ncc instead of committing node_modules.
Key Changes:
- Migrated from local development to GitHub Codespaces with cloud-based environment
- Replaced step-tracking files with issue-based exercise-toolkit automation
- Restructured action to live at repository root with
dist/index.jsbundling approach - Changed workflow trigger from issue labels to
/jokecomments
Reviewed Changes
Copilot reviewed 34 out of 35 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updated exercise description, prerequisites, and start instructions to reflect Codespaces-based workflow |
| .devcontainer/devcontainer.json | Added devcontainer configuration for GitHub Codespaces with Node.js support |
| .github/workflows/*.yml | Replaced legacy step workflows with new step-based workflows using exercise-toolkit automation |
| .github/steps/*.md | Replaced old step instructions with new Codespaces-oriented content and bundling approach |
| .github/dependabot.yml | Removed Dependabot configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Christopher W. Blake <chriswblake@github.com>
Co-authored-by: Christopher W. Blake <chriswblake@github.com>
Updated instructions for monitoring the Joke Action workflow.
I thought about this but didn't see a good use case here but maybe the "amount of jokes" could be a decent idea Might come in a later update. Adding inputs would also mean explaining Merging as is for now. |
Major changes
node_modulescommited - instead bundling todist/index.jsusingvercel/nccis taught in step3/jokecomments instead of issue labelsCopilot Summary
This pull request updates the project to use GitHub Codespaces and modernizes the setup and workflow for developing JavaScript GitHub Actions. The changes streamline the onboarding process, replace legacy workflow instructions, and introduce best practices for Node.js development in a cloud-based environment. The most important changes are grouped below.
Development Environment Modernization
.devcontainer/devcontainer.jsonfile to enable GitHub Codespaces with Node.js pre-installed, supporting a cloud-based development environment..gitignoreconfiguration.Workflow and Automation Cleanup
.github/dependabot.ymland outdated step tracking files, simplifying the repository and removing unused automation. [1] [2] [3]Project Structure and Action Implementation
src/joke.js,src/main.js) and implementing the Dad Joke action logic using best practices.@vercel/ncc, ensuring dependencies are packaged efficiently for GitHub Actions usage.Legacy Documentation Removal