fix(compiler): error when ng-content fallback has translated children #63156
Conversation
packages/compiler/src/template/pipeline/src/phases/resolve_i18n_element_placeholders.ts
Outdated
Show resolved
Hide resolved
| currentOps!.i18nBlock, | ||
| pendingStructuralDirective, | ||
| ); | ||
| pendingStructuralDirective = undefined; |
There was a problem hiding this comment.
This was also copied, but I'd expect this to be irrelevant for projected views?
There was a problem hiding this comment.
I don't have the full context on it, but I think we still need it because the Projection op might not have a i18nPlaceholder in which case the pendingStructuralDirective won't have been reset further up.
There was a problem hiding this comment.
Ah, I see; I missed that it's passed into the recordTemplate* calls.
Fixes that the pipeline wasn't processing the fallback content of `ng-content` for i18n which resulted in a compiler error further down the line. Fixes angular#63065.
57cd3db to
d369df8
Compare
|
This PR was merged into the repository by commit 5b3933f. The changes were merged into the following branches: main, 20.1.x, 20.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes that the pipeline wasn't processing the fallback content of
ng-contentfor i18n which resulted in a compiler error further down the line.Fixes #63065.