Skip to content

fix(compiler): fixes regression with event parsing and animate prefix #63470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(compiler): fixes regression with event parsing and animate prefix #63470

wants to merge 1 commit into from

Conversation

@thePunderWoman
Copy link
Contributor

@thePunderWoman thePunderWoman commented Aug 29, 2025

The new animations was not correctly looking for the . when parsing bindings. This resulted in arbitrary event bindings creating animate.leave instruction calls.

fixes: #63466

@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels Aug 29, 2025
@ngbot ngbot bot modified the milestone: Backlog Aug 29, 2025
@thePunderWoman
fix(compiler): fixes regression with event parsing and animate prefix
c2c2e98 
The new animations was not correctly looking for the `.` when parsing bindings. This resulted in arbitrary event bindings creating animate.leave instruction calls.

fixes: angular#63466
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 29, 2025
thePunderWoman added a commit that referenced this pull request Aug 29, 2025
@thePunderWoman
fix(compiler): fixes regression with event parsing and animate prefix (…
479a919 
…#63470)

The new animations was not correctly looking for the `.` when parsing bindings. This resulted in arbitrary event bindings creating animate.leave instruction calls.

fixes: #63466

PR Close #63470
@thePunderWoman
Copy link
Contributor Author

thePunderWoman commented Aug 29, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@thePunderWoman thePunderWoman deleted the animate-compiler branch September 12, 2025 16:37
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 13, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

EventEmitter names starting with 'animate' trigger animations subsystem error in Angular >=20.2.0

3 participants

@thePunderWoman @JeanMeche @crisbeto