fix(compiler-cli): capture metadata for undecorated fields #63957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworks the logic that tracks the decorator metadata for members to do so using the output AST, rather than wrapping the TypeScript AST. This makes it easier to programmatically generate new members that weren't part of the TypeScript AST before.
Adds the member decorators to the map of exposed compiler symbols.
Currently if `TestBed.overrideComponent` is used on a class that uses initializer APIs (e.g. `input()`), the initializer metadata will be wiped out, because `overrideComponent` re-compiles the class with the information set by `setClassMetadata`. `setClassMetadata` only captures decorated members at the moment. These changes introduce some logic to capture the new initializer-based APIs in `setClassMetadata` as well. Fixes angular#57944.
a04e6df to
3879d25
Compare
devversion
approved these changes
Oct 9, 2025
Member
Author
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
crisbeto
added a commit
that referenced
this pull request
Oct 9, 2025
Adds the member decorators to the map of exposed compiler symbols. PR Close #63957
crisbeto
added a commit
that referenced
this pull request
Oct 9, 2025
Currently if `TestBed.overrideComponent` is used on a class that uses initializer APIs (e.g. `input()`), the initializer metadata will be wiped out, because `overrideComponent` re-compiles the class with the information set by `setClassMetadata`. `setClassMetadata` only captures decorated members at the moment. These changes introduce some logic to capture the new initializer-based APIs in `setClassMetadata` as well. Fixes #57944. PR Close #63957
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Oct 9, 2025
…ar#63957) Reworks the logic that tracks the decorator metadata for members to do so using the output AST, rather than wrapping the TypeScript AST. This makes it easier to programmatically generate new members that weren't part of the TypeScript AST before. PR Close angular#63957
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Oct 9, 2025
Adds the member decorators to the map of exposed compiler symbols. PR Close angular#63957
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Oct 9, 2025
…3957) Currently if `TestBed.overrideComponent` is used on a class that uses initializer APIs (e.g. `input()`), the initializer metadata will be wiped out, because `overrideComponent` re-compiles the class with the information set by `setClassMetadata`. `setClassMetadata` only captures decorated members at the moment. These changes introduce some logic to capture the new initializer-based APIs in `setClassMetadata` as well. Fixes angular#57944. PR Close angular#63957
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 9, 2025
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 9, 2025
…64317) Currently if `TestBed.overrideComponent` is used on a class that uses initializer APIs (e.g. `input()`), the initializer metadata will be wiped out, because `overrideComponent` re-compiles the class with the information set by `setClassMetadata`. `setClassMetadata` only captures decorated members at the moment. These changes introduce some logic to capture the new initializer-based APIs in `setClassMetadata` as well. Fixes #57944. PR Close #63957 PR Close #64317
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at #63904.
Currently if
TestBed.overrideComponentis used on a class that uses initializer APIs (e.g.input()), the initializer metadata will be wiped out, becauseoverrideComponentre-compiles the class with the information set bysetClassMetadata.setClassMetadataonly captures decorated members at the moment.These changes introduce some logic to capture the new initializer-based APIs in
setClassMetadataas well.Fixes #57944.