-
Notifications
You must be signed in to change notification settings - Fork 26.8k
fix(migrations): migrating input with more than 1 usage in a method #64367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...ics/migrations/signal-migration/src/passes/reference_migration/helpers/standard_reference.ts
Outdated
Show resolved
Hide resolved
...ics/migrations/signal-migration/src/passes/reference_migration/helpers/standard_reference.ts
Show resolved
Hide resolved
...ics/migrations/signal-migration/src/passes/reference_migration/helpers/standard_reference.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also make sure to rescope the commit message/PR.
This is a migration fix, not a core.
2a8cb1e to
87bf24e
Compare
|
@JeanMeche I made the requested changes. Now the golden tests shouldn't fail, and I also rewrote some parts of the code. |
migration scope doesn't exist. What do I choice? I usually choice "core" |
|
It's |
87bf24e to
14188bc
Compare
I updated also the PR title |
...ics/migrations/signal-migration/src/passes/reference_migration/helpers/standard_reference.ts
Outdated
Show resolved
Hide resolved
14188bc to
24ddea0
Compare
...ics/migrations/signal-migration/src/passes/reference_migration/helpers/standard_reference.ts
Outdated
Show resolved
Hide resolved
...ics/migrations/signal-migration/src/passes/reference_migration/helpers/standard_reference.ts
Outdated
Show resolved
Hide resolved
24ddea0 to
d0010e7
Compare
d0010e7 to
b7ce35f
Compare
packages/core/schematics/migrations/signal-migration/test/golden.txt
Outdated
Show resolved
Hide resolved
b7ce35f to
f7624eb
Compare
When the migration command was run for inputs, if the input had more than one reference in a method the migration would generate incorrect code Fixes angular#63018
f7624eb to
a181aac
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When the migration command was run for inputs, if the input had more than one reference in a method the migration would generate incorrect code
Fixes #63018
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #63018
What is the new behavior?
New code after migration:
Does this PR introduce a breaking change?