Apex Command Button using action and onclick not working

Question

What I'm trying to do is have an Apex command button that on the click opens a new VF page and also, have an action that does some backend query to get data ready for the popup VF page.

Not sure why this isn't working. Anyways, here's my code :

These next two blocks of code are located on the same VF page FYI :

<apex:outputPanel>
   <apex:inputText required="true" label="Source"/>
      <!--<input type="button" onclick="openPopup()" value="open popup"/>-->
      <apex:commandButton value="open popup" onclick="openPopup()" action="{!executeQuery}"/>
</apex:outputPanel>




 <script type="text/javascript">
    var newWindow = null;
    function openPopup() {
      newWindow = window.open('OMTCustomPage2', 'Popup', 'height=500, width=500');
    }

    function closePopup(object,name) {
      if(newWindow!=null)
         newWindow.close();
    }
 </script>

And this is in the 2nd VF page which is the popup :

 <script type="text/javascript">
    var newWindow = null;

    function openPopup() {
      newWindow = window.open('OMTCustomPage2', 'Popup', 'height=500, width=500');
    }

    function closePopup(object,name) {
      if(newWindow!=null)
          newWindow.close();
    }
</script>

Caspar Harmer · Accepted Answer · 2016-07-31 23:01:45Z

1

You command button is actually running the action method in it's own onclick handler (you would normally not define an onclick handler on a command button).

Try this instead:

<apex:commandButton value="open popup" oncomplete="openPopup()" action="{!executeQuery}"/>

What this does is run your back-end query, then open the popup. You can't easily do this asynchronously.

Make sure that your return value for this controller function returns either void or a null PageReference.

answered Jul 31, 2016 at 23:01

Caspar Harmer

20.6k4 gold badges37 silver badges69 bronze badges

Thanks! Yeah, that makes sense. I was thinking something around there too but I'm still new to VF so didn't want to make an assumption without an expert's thoughts. Thanks again! Have an awesome day!

user2582622
– user2582622

2016-07-31 23:14:03 +00:00
Commented Jul 31, 2016 at 23:14

Add a comment |

Stack Exchange Network

Apex Command Button using action and onclick not working

1 Answer 1

You must log in to answer this question.

Hot Network Questions

Apex Command Button using action and onclick not working

1 Answer 1

You must log in to answer this question.

Related

Hot Network Questions