onclick Javascript failing to pass If Condition

Question

What could be wrong with this code? I'm fairly new to javascript and I've been trying to debug on my own to no avail.

The alert('confirmed: ' + records[i].ENQ_Confirmed_with_Enbridge__c); shows false but it won't pass the if condition so my counter isn't incrementing.

Same goes with if(records[i].ENQ_QSC_Notified__c === false even if the value of the field is false, it doesn't pass the condition as well.

var assPac = new sforce.SObject("ENQ_Assignment_Package__c"); 
var qscContact = '{!ENQ_Assignment_Package__c.ENQ_QSC_Contact__c}'; 
var status = '{!ENQ_Assignment_Package__c.ENQ_Status__c}'; 
var otherP = sforce.connection.query("Select 
              Id,ENQ_Confirmed_with_Enbridge__c,ENQ_QSC_Notified__c FROM 
              ENQ_QSR_Assignment__c where ENQ_Assignment_Package__c = 
              '{!ENQ_Assignment_Package__c.Id}'");
var records = otherP.getArray("records");

for(var i=0; i<records.length; i++){
alert('confirmed: ' + records[i].ENQ_Confirmed_with_Enbridge__c);
if(records[i].ENQ_Confirmed_with_Enbridge__c === false){
   alert('check');
   counter++;    
}
 alert('counter: ' + counter);
if(records[i].ENQ_QSC_Notified__c === false){
   records[i].ENQ_QSC_Notified__c = true;
   qscNotified.push(records[i]);
}

}
alert('qscNotified: ' + qscNotified.length);

Any help would be appreciated.

sfdcfox · Accepted Answer · 2017-10-18 00:50:21Z

1

You should be using getBoolean if you want to do a direct comparison:

if(records[i].getBoolean('ENQ_QSC_Notified__c') === false){

I'd probably recommend this approach for most normal situations.

answered Oct 18, 2017 at 0:50

sfdcfox

1

Add a comment |

Loren · Accepted Answer · 2017-10-18 00:01:52Z

0

I figured it now with the help of reading this related question(Is there a bug in the way custom buttons handle checkboxes on related objects?). So the boolean has to be enclosed in quotes, where I'm not used to. That was difficult to debug, though.

answered Oct 18, 2017 at 0:01

Loren

843 silver badges11 bronze badges

1

That is simply because you're getting a string representation of the result in your return from the apex. SFDCFox answer willl work great as it converts the string value to an actual boolean and compares to a boolean. Both approaches will work - however i must agree with his route being cleaner and less prone to error.

Ronnie
– Ronnie

2017-10-20 03:04:14 +00:00
Commented Oct 20, 2017 at 3:04

Add a comment |

Stack Exchange Network

onclick Javascript failing to pass If Condition

2 Answers 2

You must log in to answer this question.

Linked

Hot Network Questions

onclick Javascript failing to pass If Condition

2 Answers 2

You must log in to answer this question.

Linked

Related

Hot Network Questions