JSON parsing an array - not reading object

Question

Consider the following class, modified from this gist https://gist.github.com/sravalaparthi/69d76a710fb3689b0859 when it creates the objectWrapper object (qw), it's not populating it with the parsed JSON object. Can anyone see what I'm doing wrong here?

    public class JSONParserDemo {

    String jsonstring ='{"item":[{"field1":"0040030579","field2":"2014-01-30",'
                + '"field3":"100","field4":"2014-01-30"}]}';
    List<objectWrapper> parsedObjects = new List<objectWrapper>();

    public List<objectWrapper> getparsedObjects(){
        // Create a JSON Parser from String.
        JSONParser parser = JSON.createParser(jsonstring);
        string s = jsonstring;
        while (parser.nextToken() != null) {
            if ((parser.getCurrentToken() == JSONToken.FIELD_NAME) &&
                (parser.getText() == 'item')){
                system.debug('found "item"');   // finds this ok ("item")
                 s = (String)parser.readValueAs(String.class);
                system.debug('s = ' + JSON.serialize(s));
                while (parser.nextToken() != null) {
                    // Check for JSON array starting.
                    // START_ARRAY This token is returned when '[' is encountered.
                    if (parser.getCurrentToken() == JSONToken.START_ARRAY) {
                        system.debug('found START_ARRAY');      // finds this ok ("[")
                         s = (String)parser.readValueAs(String.class);
                        system.debug('s = ' + JSON.serialize(s));
                        // Check for JSON object starting
                        //  START_OBJECT This token is returned when '{' is encountered.
                        while (parser.nextToken() != null) {
                            if (parser.getCurrentToken() == JSONToken.START_OBJECT) {
                                system.debug('found START_OBJECT: ' + parser.getText());    // finds this ok ("{")
                                // Read entire object, including its array of line items.
                                objectWrapper qw = ( objectWrapper)parser.readValueAs(objectWrapper.class);
                                system.debug('qw = ' + JSON.serialize(qw));     // returns a null object :(
                                parsedObjects.add(qw);
                                parser.skipChildren();
                            }
                        }
                    }
                }
            }
        }
         return parsedObjects;  
    }

    //Inner class of required JSON object type
    public class objectWrapper
  {
        public string f1 {get;set;}
        public string f2 {get;set;}
        public string f3 {get;set;}
        public string f4 {get;set;}
  }

}

Thanks.

try running you JSON through json2apex.com and compare the class generated to yours. — Eric
– Eric, Commented Nov 10, 2015 at 17:47

sfdcfox · Accepted Answer · 2015-11-10 17:50:50Z

1

The values in your JSON are field1, field2, field3, and field4, but in your wrapper class, defined only as f1, f2, f3, and f4. The names need to match in order to use readValueAs. Your code is about as complicated as it could be. Here's how I'd parse your incredibly complex example:

public class Item {
    public String field1;
    public String field2;
    public String field3;
    public String field4;
}

public class Wrapper {
    public List<Item> item;
}

public static Wrapper parse(String json) {
    return (Wrapper) System.JSON.deserialize(json, Wrapper.class);
}

You should generally leave parsing of this complexity to objects that would be difficult/impossible to model in generic code, perhaps because of field names or depth complexity.

answered Nov 10, 2015 at 17:50

sfdcfox

1

Thanks sfdcfox. I stripped out some extra fields from the JSON string (some other fields than "item", e.g. "{"somefield":"somevalue","item":"{[...]}", etc.) to kind of dumb down the actual string I was trying to parse. Appreciate the info on the fields names matching the class though, didn't really think of that!

Leapin Dave
– Leapin Dave

2015-11-10 19:23:07 +00:00
Commented Nov 10, 2015 at 19:23

Add a comment |

Adele · Accepted Answer · 2015-11-11 14:41:02Z

0

I would recommand to validate and format JSON data first using http://jsonformatter.org

answered Nov 11, 2015 at 14:41

Adele

11 bronze badge

Add a comment |

Stack Exchange Network

JSON parsing an array - not reading object

2 Answers 2

You must log in to answer this question.

Hot Network Questions

JSON parsing an array - not reading object

2 Answers 2

You must log in to answer this question.

Related

Hot Network Questions