]> BookStack Code Mirror - bookstack/log
bookstack
2 years agoJS: Fixed ESLint issues 4578/head
Dan Brown [Sun, 1 Oct 2023 17:13:54 +0000 (18:13 +0100)]
JS: Fixed ESLint issues

2 years agoImages: Rolled out image memory handling to image actions
Dan Brown [Sun, 1 Oct 2023 12:05:18 +0000 (13:05 +0100)]
Images: Rolled out image memory handling to image actions

- Moved thumnbail loading out of repo into ImageResizer.
- Updated gallery and editor image handling to show errors where
  possible to indicate memory issues for resizing/thumbs.
- Updated gallery to load image data in a per-image basis via edit form
  for more resiliant thumb/data fetching. Data was previously provided
  via gallery listing, which could be affected by failing generation
  of other images.
- Updated image manager double click handling to be more pleasant and
  not flash away the edit form.
- Updated editor handlers to use main URL when thumbs fail to load.

2 years agoImages: Extracted out image resizing to its own class
Dan Brown [Sat, 30 Sep 2023 19:00:48 +0000 (20:00 +0100)]
Images: Extracted out image resizing to its own class

2 years agoImages: Added thin wrapper around image filesystem instances
Dan Brown [Sat, 30 Sep 2023 18:12:22 +0000 (19:12 +0100)]
Images: Added thin wrapper around image filesystem instances

Extracts duplicated required handling (Like path adjustment) out to
simpler storage disk instance which can be passed around.

2 years agoImages: Started refactor of image service
Dan Brown [Sat, 30 Sep 2023 17:28:42 +0000 (18:28 +0100)]
Images: Started refactor of image service

To break it up.
Also added better memory handling to other parts of the app.

2 years agoImage manager: Tweaked grid sizing to prevent massive items
Dan Brown [Sat, 30 Sep 2023 11:43:51 +0000 (12:43 +0100)]
Image manager: Tweaked grid sizing to prevent massive items

2 years agoImages: Added test to cover thubmnail regen endpoint
Dan Brown [Sat, 30 Sep 2023 11:29:49 +0000 (12:29 +0100)]
Images: Added test to cover thubmnail regen endpoint

2 years agoImages: Reverted some thumbnails to be on-demand generated
Dan Brown [Sat, 30 Sep 2023 11:09:29 +0000 (12:09 +0100)]
Images: Reverted some thumbnails to be on-demand generated

Added since we can't always be sure of future image usage, and in many
cases we don't generate ahead-of-time.
Also:
- Simplified image handling on certain models.
- Updated various string handling operations to use newer functions.

2 years agoThumbnails: Added OOM handling and regen endpoint
Dan Brown [Fri, 29 Sep 2023 12:54:08 +0000 (13:54 +0100)]
Thumbnails: Added OOM handling and regen endpoint

- Added some level of app out-of-memory handling so we can show a proper
  error message upon OOM events.
- Added endpoint and image-manager button/action for regenerating
  thumbnails for an image so they can be re-created upon failure.

2 years agoImages: Updated to create thumbnails at specific events
Dan Brown [Fri, 29 Sep 2023 10:45:31 +0000 (11:45 +0100)]
Images: Updated to create thumbnails at specific events

2 years agoUploads: Added user-facing message for Laravel post limit handling
Dan Brown [Mon, 25 Sep 2023 12:48:23 +0000 (13:48 +0100)]
Uploads: Added user-facing message for Laravel post limit handling

Uploads over the post max size Would previously error without a
clean user facing message. This catches that error to provide a
user friendly message, compatible with our common error handling.

Tested on image manager handling.
Added test to cover.

2 years agoEditors: Updated entity link select to pre-fill with selection
Dan Brown [Sun, 24 Sep 2023 17:33:33 +0000 (18:33 +0100)]
Editors: Updated entity link select to pre-fill with selection

Updated all uses across both editors, so the entity link selector popup
now initates a search with the selection text if existing.

For #4571

2 years agoExports: Fixed issues with book text export format
Dan Brown [Sun, 24 Sep 2023 17:03:37 +0000 (18:03 +0100)]
Exports: Fixed issues with book text export format

- Fixed missing page content for direct page children
- Fixed lack of book description.
- Fixed inconsistent spacing between items.
- Fixed lack of spacing between HTML items when HTML on same line.

For #4557

2 years agoHeader: Simplified, split and re-orgranised view file(s)
Dan Brown [Sun, 24 Sep 2023 09:29:51 +0000 (10:29 +0100)]
Header: Simplified, split and re-orgranised view file(s)

- Moved "common" template partials, that are only used in layouts, to
  layouts/parts folder.
- Simplified HTML structure of header template.
- Extracted logo and links from header template to simplify.
- Added header-links-start template for easier extension/customization
  without needing to override full list of links.
  - Added test to cover usage of this.

For #4564

2 years agoHomepage: Added tags button to non-default home views
Dan Brown [Sun, 24 Sep 2023 08:31:44 +0000 (09:31 +0100)]
Homepage: Added tags button to non-default home views

For #4558

2 years agoSearch: Added further backslash handling
Dan Brown [Sat, 23 Sep 2023 12:41:10 +0000 (13:41 +0100)]
Search: Added further backslash handling

Added due to now not being able to perform an exact search where
contains a trailing backslash.
Now all backslashes in exact terms are consided escape chars
and require escaping themselves.
Potential breaking change due to search syntax handling change.

Related to #4535.

2 years agoReadme: Updated badges, sponsors and top links
Dan Brown [Sat, 23 Sep 2023 11:47:24 +0000 (12:47 +0100)]
Readme: Updated badges, sponsors and top links

2 years agoSearch: Added support for escaped exact terms
Dan Brown [Tue, 19 Sep 2023 19:09:33 +0000 (20:09 +0100)]
Search: Added support for escaped exact terms

Also prevented use of empty exact matches.
Prevents issues when attempting to use exact search terms in inputs for
just search terms, and use of single " chars within search terms since
these would get auto-promoted to exacts.

For #4535

2 years agoAvatar Commend: Simplified and updated during review
Dan Brown [Tue, 19 Sep 2023 14:53:01 +0000 (15:53 +0100)]
Avatar Commend: Simplified and updated during review

During review of #4560.

- Simplified command to share as much log as possible across different
  run options.
- Extracted out user handling to share with MFA command.
- Added specific handling for disabled avatar fetching.
- Added mention of avatar endpoint, to make it clear where these avatars
  are coming from (Protect against user expectation of LDAP avatar sync).
- Simplified a range of the testing.
- Tweaked wording and code formatting.

2 years agofix: Actually check if we have correct data 4560/head
Marc Hagen [Mon, 18 Sep 2023 18:04:59 +0000 (20:04 +0200)]
fix: Actually check if we have correct data

2 years agofeat: Artisan command for updating avatars for existing users
Marc Hagen [Mon, 18 Sep 2023 17:07:30 +0000 (19:07 +0200)]
feat: Artisan command for updating avatars for existing users

2 years agoDev: Reviewed and expanded on PHP testing docs
Dan Brown [Sun, 17 Sep 2023 22:41:02 +0000 (23:41 +0100)]
Dev: Reviewed and expanded on PHP testing docs

2 years agoMerge branch 'tusharnain4578/development' into development
Dan Brown [Sun, 17 Sep 2023 21:29:06 +0000 (22:29 +0100)]
Merge branch 'tusharnain4578/development' into development

2 years agoNotifications: Updated comment notif. prefs. test
Dan Brown [Sun, 17 Sep 2023 21:26:51 +0000 (22:26 +0100)]
Notifications: Updated comment notif. prefs. test

Combined testcases, updated to use actual text strings, and set comments
setting via correct method.

Made during review of #4552

2 years agoMerge pull request #4555 from BookStackApp/language_cleanup
Dan Brown [Sun, 17 Sep 2023 21:15:38 +0000 (22:15 +0100)]
Merge pull request #4555 from BookStackApp/language_cleanup

Language cleanup

2 years agoLocales: Removed a lot of existing locale handling 4555/head
Dan Brown [Sun, 17 Sep 2023 21:02:12 +0000 (22:02 +0100)]
Locales: Removed a lot of existing locale handling

There was a lot of locale handling to get correct/expected date
formatting within the app.
Carbon now has built-in locale content rather than us needing to target
specific system locales.

This also removes setting locale via Carbon directly.
Carbon registers its own Laravel service provider which seems to
accurately pull the correct locale from the app.

For #4555

2 years agoUpdate UserPreferencesTest.php 4552/head
Tushar Nain [Sun, 17 Sep 2023 18:01:01 +0000 (23:31 +0530)]
Update UserPreferencesTest.php

Added Testcases for preferences menu of Comment Notifications visibility when comments are enabled/disabled.

2 years agoLocales: Fixed errors occuring for PHP < 8.2
Dan Brown [Sun, 17 Sep 2023 16:35:00 +0000 (17:35 +0100)]
Locales: Fixed errors occuring for PHP < 8.2

2 years agoLocales: More use of locale objects, Addressed failing tests
Dan Brown [Sun, 17 Sep 2023 15:20:21 +0000 (16:20 +0100)]
Locales: More use of locale objects, Addressed failing tests

2 years agoLocales: Performed cleanup and alignment of locale handling
Dan Brown [Sun, 17 Sep 2023 12:29:06 +0000 (13:29 +0100)]
Locales: Performed cleanup and alignment of locale handling

- Reduced app settings down to what's required.
- Used new view-shared $locale object instead of using globals via
  config.
- Aligned language used to default on "locale" instead of mixing
  locale/language.

For #4501

2 years agoExtracted icon helper, aligned container resolution
Dan Brown [Sat, 16 Sep 2023 17:25:08 +0000 (18:25 +0100)]
Extracted icon helper, aligned container resolution

Also updated breadcrumb view composer to current standards.
Closes #4553

2 years agoMerge pull request #4554 from BookStackApp/guest_user_cleanup
Dan Brown [Sat, 16 Sep 2023 12:59:16 +0000 (13:59 +0100)]
Merge pull request #4554 from BookStackApp/guest_user_cleanup

Guest control: Cleaned methods involved in fetching/handling

2 years agoRemoved redundant null check 4554/head
Dan Brown [Sat, 16 Sep 2023 12:49:03 +0000 (13:49 +0100)]
Removed redundant null check

2 years agoGuest control: Cleaned methods involved in fetching/handling
Dan Brown [Sat, 16 Sep 2023 12:18:35 +0000 (13:18 +0100)]
Guest control: Cleaned methods involved in fetching/handling

- Moves guest user caching from User class to app container for
  simplicity.
- Updates test to use simpler $this->users->guest() method for
  consistency.
- Streamlined helpers to avoid function overlap for simplicity.
- Extracted user profile dropdown while doing changes.

2 years agoMerge branch 'v23-08' into development
Dan Brown [Sat, 16 Sep 2023 10:55:57 +0000 (11:55 +0100)]
Merge branch 'v23-08' into development

2 years agoFixed : Comment notification settings are visible even if comments are disabled
Tushar Nain [Sat, 16 Sep 2023 08:30:08 +0000 (14:00 +0530)]
Fixed : Comment notification settings are visible even if comments are disabled

Added a UX condition to display comment notification settings, only if the user has enabled the comment notifications.

2 years agoComments: Fixed wrong identification of parent comment
Dan Brown [Fri, 15 Sep 2023 12:38:02 +0000 (13:38 +0100)]
Comments: Fixed wrong identification of parent comment

Would cause comment reply notifications to not be sent to expected user.
Updated test to cover problem case.

For #4548

2 years agoCleanup Command: Allowed running non-interactively
Dan Brown [Thu, 14 Sep 2023 13:17:20 +0000 (14:17 +0100)]
Cleanup Command: Allowed running non-interactively

For #4541

2 years agoDark Mode: Fixed not toggle action when dark by default
Dan Brown [Thu, 14 Sep 2023 12:53:24 +0000 (13:53 +0100)]
Dark Mode: Fixed not toggle action when dark by default

Added test to cover.
For #4543.

2 years agoLangs: Added Uzbek, Updated translator attribution
Dan Brown [Wed, 13 Sep 2023 09:52:12 +0000 (10:52 +0100)]
Langs: Added Uzbek, Updated translator attribution

For #4527

2 years agoMerge branch 'Bajszi97/development' into development
Dan Brown [Wed, 13 Sep 2023 09:12:49 +0000 (10:12 +0100)]
Merge branch 'Bajszi97/development' into development

2 years agoReviewed #4533, formatting and tweaks
Dan Brown [Wed, 13 Sep 2023 09:09:33 +0000 (10:09 +0100)]
Reviewed #4533, formatting and tweaks

- Updating formatting.
- Tweaked truncation to roughly match elipsis char to width used.
- Updated testing to use existing helpers, and ran check as admin user
  to avoid name conflicts.

2 years agoTest comment creator name truncation 4533/head
Bajszi [Tue, 12 Sep 2023 19:00:00 +0000 (21:00 +0200)]
Test comment creator name truncation

2 years agoTruncate with three dots
Bajszi [Tue, 12 Sep 2023 15:03:57 +0000 (17:03 +0200)]
Truncate with three dots

2 years agoTheme: Added handling for functions.php file load error
Dan Brown [Tue, 12 Sep 2023 11:34:02 +0000 (12:34 +0100)]
Theme: Added handling for functions.php file load error

This adds specific handling for functions.php error loading to re-throw
errors wrapped in a more descriptive message, to make it clear the error
is due to an issue in their functions.php file.

Decided to throw and stop, rather than ignore & continue, to be on the
safe side in the event auth-level (or other security level) customizations
have been made via functions.php.

Adds test to cover.
Closes #4504

2 years agoTrimmed name last resort
Bajszi [Mon, 11 Sep 2023 19:27:15 +0000 (21:27 +0200)]
Trimmed name last resort

2 years agoNotifications: Reorgranised classes into domain specific folders
Dan Brown [Mon, 11 Sep 2023 18:26:28 +0000 (19:26 +0100)]
Notifications: Reorgranised classes into domain specific folders

Closes #4500

2 years agoViews: Rolled out ID to similar recent activity lists
Dan Brown [Mon, 11 Sep 2023 17:50:39 +0000 (18:50 +0100)]
Views: Rolled out ID to similar recent activity lists

To allow for easier customization.
Related to #4530

2 years agoMerge branch 'v23-08' into development
Dan Brown [Mon, 11 Sep 2023 17:43:23 +0000 (18:43 +0100)]
Merge branch 'v23-08' into development

2 years agoComments: Fixed JS error when lacking commenting permissions
Dan Brown [Mon, 11 Sep 2023 17:40:40 +0000 (18:40 +0100)]
Comments: Fixed JS error when lacking commenting permissions

The page comments component would throw an error due to references to
form elements/content, when form elements may not exist due to
permisisons.

For #4531

2 years agoSlack auth: Switched from community to laravel library
Dan Brown [Mon, 11 Sep 2023 14:26:04 +0000 (15:26 +0100)]
Slack auth: Switched from community to laravel library

Tested locally before & after change, and looked at code to compare.
Nothing seen or experienced that should affect things, from testing all
is working as expected with no difference from before.
- Update composer requirement of socialite to that which included slack.
- Updated PHP depds while there.
- Updated format of socialite events to align with current documentation
  and to use class references instead of strings.

2 years agoOIDC: Moved name claim option handling from config to service
Dan Brown [Mon, 11 Sep 2023 10:50:58 +0000 (11:50 +0100)]
OIDC: Moved name claim option handling from config to service

Closes #4494

2 years agoFixed php8 compat issue, updated readme & templates
Dan Brown [Mon, 11 Sep 2023 10:37:07 +0000 (11:37 +0100)]
Fixed php8 compat issue, updated readme & templates

- Changed use of array spread since it was not supported in PHP8.0.
- Updated issue templates based to reduce less valueable fields, update
  some details, and try to help bug reports be more focused on bugs.
- Updated readme with peertube link and attribution advistory for
  translations PRs.

2 years agoSimplified and aligned handling of mixed entity endpoints
Dan Brown [Sun, 10 Sep 2023 14:18:31 +0000 (15:18 +0100)]
Simplified and aligned handling of mixed entity endpoints

Fixes #4444

2 years agoMail: changed default "MAIL_FROM" address
Dan Brown [Sat, 9 Sep 2023 11:39:01 +0000 (12:39 +0100)]
Mail: changed default "MAIL_FROM" address

Used an "example.com" address so we're using a propoer reserved domain,
and to avoid these trying to be delivered to the main bookstackapp
domain.

Closes #4518

2 years agoMerge pull request #4525 from BookStackApp/http_alignment
Dan Brown [Fri, 8 Sep 2023 16:30:44 +0000 (17:30 +0100)]
Merge pull request #4525 from BookStackApp/http_alignment

HTTP calling logic alignment

2 years agoRemoved use of HttpFetcher 4525/head
Dan Brown [Fri, 8 Sep 2023 16:16:57 +0000 (17:16 +0100)]
Removed use of HttpFetcher

- Fixed some existing issues in new aligned process.
- Manually tested each external call scenario.

2 years agoStarted aligning app-wide outbound http calling behaviour
Dan Brown [Fri, 8 Sep 2023 13:16:09 +0000 (14:16 +0100)]
Started aligning app-wide outbound http calling behaviour

2 years agoUpdated translations with latest Crowdin changes (#4512)
Dan Brown [Thu, 7 Sep 2023 14:57:59 +0000 (15:57 +0100)]
Updated translations with latest Crowdin changes (#4512)

Last translation merge for possible continued v23.08 branch

2 years agoUpdated sponsors and dev version
Dan Brown [Thu, 7 Sep 2023 13:43:29 +0000 (14:43 +0100)]
Updated sponsors and dev version

2 years agoUpdated translations with latest Crowdin changes (#4506)
Dan Brown [Mon, 4 Sep 2023 10:48:25 +0000 (11:48 +0100)]
Updated translations with latest Crowdin changes (#4506)

2 years agoWYSIWYG: Fixed filtering issue causing broken page edits
Dan Brown [Mon, 4 Sep 2023 10:25:05 +0000 (11:25 +0100)]
WYSIWYG: Fixed filtering issue causing broken page edits

Could error upon div elements without classes, including drawings.

Related to #4510 and #4509

2 years agoUpdated translator attribution before release v23.08.1
Dan Brown [Sun, 3 Sep 2023 16:35:57 +0000 (17:35 +0100)]
Updated translator attribution before release v23.08.1

2 years agoUpdated translations with latest Crowdin changes (#4481)
Dan Brown [Sun, 3 Sep 2023 16:23:40 +0000 (17:23 +0100)]
Updated translations with latest Crowdin changes (#4481)

2 years agoPreferences: Fixed section screen flexibility
Dan Brown [Sun, 3 Sep 2023 15:58:29 +0000 (16:58 +0100)]
Preferences: Fixed section screen flexibility

Improved wrapping and flex control to prevent button text force wrapping
to newlines.

For #4502

2 years agoWatching: Prevent issues when watchable or user is deleted
Dan Brown [Sun, 3 Sep 2023 13:19:43 +0000 (14:19 +0100)]
Watching: Prevent issues when watchable or user is deleted

- Adds filtering to the watched items list in notification preferences
  so that deleted (recycle bin) items are removed via query.
- Adds relations and logic to properly remove watches upon user and
  entity delete events, to old watches in database do not linger.
- Adds testing to cover the above.

Did not add migration for existing data, since patch will be close to
introduction, and lingering DB entries don't open a security concern,
just some potential confusion in specific potential scenarios.
Probably not work extra migration risk, although could add in future if
concerns/issues are found.

Related to #4499

2 years agoMerge pull request #4497 from BookStackApp/notification_language
Dan Brown [Sat, 2 Sep 2023 14:47:26 +0000 (15:47 +0100)]
Merge pull request #4497 from BookStackApp/notification_language

Notifications: User language for notification text

2 years agoMerge pull request #4484 from omahs/patch-1
Dan Brown [Sat, 2 Sep 2023 14:44:01 +0000 (15:44 +0100)]
Merge pull request #4484 from omahs/patch-1

Fix typos

2 years agoTesting: Added entity decode flag and phpunit env option 4497/head
Dan Brown [Sat, 2 Sep 2023 14:39:45 +0000 (15:39 +0100)]
Testing: Added entity decode flag and phpunit env option

- Passed decode flags to provide consistent behaviour across PHP
  versions during testing.
- Added env option to prevent local option taking action in PHPunit
  tests.

2 years agoNotifications: Aligned how user language is used
Dan Brown [Sat, 2 Sep 2023 14:11:42 +0000 (15:11 +0100)]
Notifications: Aligned how user language is used

- This ensures content notifications are not translated to receiver
  language.
- This adds actual plaintext support for content notifications (Was
  previously just HTML as text view).
- Shares same base class across all mail notifications.
- Also cleaned up existing notification classes.

Future cleanup requested via #4501

2 years agoNotifications: Add test to check notification language
Dan Brown [Fri, 1 Sep 2023 15:30:37 +0000 (16:30 +0100)]
Notifications: Add test to check notification language

2 years agoWYSIWYG: Added filtering of page pointer elements
Dan Brown [Fri, 1 Sep 2023 12:50:55 +0000 (13:50 +0100)]
WYSIWYG: Added filtering of page pointer elements

For #4474

2 years agofix typo 4484/head
omahs [Thu, 31 Aug 2023 08:01:56 +0000 (10:01 +0200)]
fix typo

2 years agofix typos
omahs [Thu, 31 Aug 2023 08:00:45 +0000 (10:00 +0200)]
fix typos

2 years agofix typo
omahs [Thu, 31 Aug 2023 07:58:59 +0000 (09:58 +0200)]
fix typo

2 years agoUpdated translations with latest Crowdin changes (#4462)
Dan Brown [Wed, 30 Aug 2023 11:35:10 +0000 (12:35 +0100)]
Updated translations with latest Crowdin changes (#4462)

2 years agoUpdated translator attribution before v23.08
Dan Brown [Wed, 30 Aug 2023 10:49:45 +0000 (11:49 +0100)]
Updated translator attribution before v23.08

2 years agoMD Editor: Fixed scroll on mobile widths
Dan Brown [Wed, 30 Aug 2023 01:41:51 +0000 (02:41 +0100)]
MD Editor: Fixed scroll on mobile widths

Added min-height to flex elements to ensure they properly flex within
the container rathen than adjust to content.

For #4466

2 years agoSSR: Added new option to complete env example file
Dan Brown [Wed, 30 Aug 2023 01:31:36 +0000 (02:31 +0100)]
SSR: Added new option to complete env example file

2 years agoMerge branch 'srr_host_allowlist' into development
Dan Brown [Sun, 27 Aug 2023 11:45:00 +0000 (12:45 +0100)]
Merge branch 'srr_host_allowlist' into development

2 years agoUpdated translations with latest Crowdin changes (#4380)
Dan Brown [Sun, 27 Aug 2023 11:43:59 +0000 (12:43 +0100)]
Updated translations with latest Crowdin changes (#4380)

2 years agoSSR: Updated allow list handling & covered webhook usage
Dan Brown [Sat, 26 Aug 2023 19:13:37 +0000 (20:13 +0100)]
SSR: Updated allow list handling & covered webhook usage

- Covered webhook SSR allow list useage via test.
- Updated allow list handling to use trailing slash, or hash, or end of
  line as late anchor for better handling for hosts (prevent .co.uk
passing for .co domain host)

2 years agoSecurity: Added new SSR allow list and validator
Dan Brown [Sat, 26 Aug 2023 14:28:29 +0000 (15:28 +0100)]
Security: Added new SSR allow list and validator

Included unit tests to cover validator functionality.
Added to webhooks.
Still need to do testing specifically for webhooks.

2 years agoGuests: Prevented access to profile routes
Dan Brown [Sat, 26 Aug 2023 13:07:48 +0000 (14:07 +0100)]
Guests: Prevented access to profile routes

Prevention of action on certain routes for guest user when public access
is enabled. Could not see a way this could be a security issue, beyond a
mild nuisance that'd only be visible if public users can edit, which
would present larger potential nuisance anyway.

2 years agoMerge pull request #4457 from BookStackApp/drawing_backup_store
Dan Brown [Wed, 23 Aug 2023 18:12:29 +0000 (19:12 +0100)]
Merge pull request #4457 from BookStackApp/drawing_backup_store

Browser-based drawing backup storage system

2 years agoUpdated readme attribution and fixed eslint issues 4457/head
Dan Brown [Wed, 23 Aug 2023 18:02:23 +0000 (19:02 +0100)]
Updated readme attribution and fixed eslint issues

2 years agoDrawio: Tweaked fail backup handling during testing
Dan Brown [Wed, 23 Aug 2023 17:50:37 +0000 (18:50 +0100)]
Drawio: Tweaked fail backup handling during testing

- Tweaked wording of popup title.
- Updated WYSIWYG create handling to properly remove drawing container
  on failure.

Tested across FF and chrome, in both editors for create & editing.

2 years agoDrawio: Added unsaved restore prompt and logic
Dan Brown [Wed, 23 Aug 2023 13:16:20 +0000 (14:16 +0100)]
Drawio: Added unsaved restore prompt and logic

2 years agoDrawio: Started browser drawing backup store system
Dan Brown [Tue, 22 Aug 2023 18:30:39 +0000 (19:30 +0100)]
Drawio: Started browser drawing backup store system

Adds just the part to store image data, and remove on successfull save.
Alters save events to properly throw upon error.
Adds IDB-Keyval library for local large-size store.
For #4421

2 years agoRTL: Fixed screen-reader-only elements pushout out view
Dan Brown [Tue, 22 Aug 2023 17:25:14 +0000 (18:25 +0100)]
RTL: Fixed screen-reader-only elements pushout out view

For #4429

2 years agoCache: Increases database cache value size
Dan Brown [Mon, 21 Aug 2023 22:01:42 +0000 (23:01 +0100)]
Cache: Increases database cache value size

Upped from text to medium text.
Aligns with modern Laravel default.
Fixes #4453 where were reaching the limit of TEXT.

2 years agoMerge branch 'add-priority' into development
Dan Brown [Mon, 21 Aug 2023 14:43:16 +0000 (15:43 +0100)]
Merge branch 'add-priority' into development

2 years agoAPI: Reviewed changes for API priority control
Dan Brown [Mon, 21 Aug 2023 14:40:53 +0000 (15:40 +0100)]
API: Reviewed changes for API priority control

Review of #4313
- Made constructor changes while reviewing some classes.
- Updated API examples for consistency.
- Tweaked formatting for some array changes.
- Simplified added tests.
- Tweaked chapter/page repo priority handling to be simpler.

Performed manual API endpoint testing of page/chapter create/update.

2 years agoUpdated PHP and npm deps, Upped node version
Dan Brown [Sat, 19 Aug 2023 19:21:12 +0000 (20:21 +0100)]
Updated PHP and npm deps, Upped node version

2 years agoStatus: Updated cache check to use unique key
Dan Brown [Thu, 17 Aug 2023 20:24:35 +0000 (21:24 +0100)]
Status: Updated cache check to use unique key

Updated status endpoint cache check to include a random component in the
key to avoid conflict during simultaneous checks.
For #4396

2 years agoMerge pull request #4390 from BookStackApp/content_notifications
Dan Brown [Thu, 17 Aug 2023 20:09:52 +0000 (21:09 +0100)]
Merge pull request #4390 from BookStackApp/content_notifications

Content user notifications

2 years agoNotifications: Switched testing from string to reference levels 4390/head
Dan Brown [Thu, 17 Aug 2023 17:10:34 +0000 (18:10 +0100)]
Notifications: Switched testing from string to reference levels

2 years agoNotifications: Fixed send content permission checking
Dan Brown [Thu, 17 Aug 2023 16:57:31 +0000 (17:57 +0100)]
Notifications: Fixed send content permission checking

Added test and changed logic to properly check the view permissions for
the notification receiver before sending.
Required change to permissions applicator to allow the user to be
manually determined, and a service provider update to provide the class
as a singleton without a specific user, so it checks the current logged
in user on demand.

2 years agoNotifications: Fixed issues causing failing tests
Dan Brown [Thu, 17 Aug 2023 13:59:28 +0000 (14:59 +0100)]
Notifications: Fixed issues causing failing tests

- Ensured watch options passed in all meta template usage to fix failing
  scenarios where watch options did not exist.
- Fixed testing issue caused by guest user permission caching.

2 years agoNotifications: Made improvements from manual testing
Dan Brown [Wed, 16 Aug 2023 19:15:49 +0000 (20:15 +0100)]
Notifications: Made improvements from manual testing

- Added titles for preference pages.
- Added extra check for non-guest for notifications on preferences page.