Django url regexp not working

Question

I'm trying to get my head around regexp in Django urls. I'm currently developing locally and I want to be able to direct a request such as http://localhost:8000/options/items/item-string-1121/ to the 'details' view in my app called 'options', passing in the final number part of the request string (1121) as a parameter 'id' to the view function.

The signature for details in options/views.py is as follows, taking id=1 as default:

def details(request, id=1):
    ...

I have the following in my root urls.py:

...

urlpatterns += patterns('',
    url(r'^options/, include(options.urls')),
)

and in options/urls.py:

urlpatterns = patterns('options.views', 
    url(r'^items/(.+)(P<id>\d+)/$', 'details'),
    ...
)

Now when I try to request the above URL the dev server says it tried to match against the pattern ^options/ ^items/(.+)(P<id>\d+)/$ but it doesn't match.

Can anyone see the problem?

There is not need to capture unnamed group, r'^items/.+-(?P<id>\d+)/$' is fine. — okm
– okm, Commented Apr 28, 2012 at 18:43

coderanger · Accepted Answer · 2012-04-28 18:07:34Z

3

You need a non-greedy quantifier on the (.+), so r'^items/(.+?)(P\d+)/$'. Otherwise that first glob happily eats until the end of the string, preventing the ID from ever matching.

answered Apr 28, 2012 at 18:07

coderanger

54.6k4 gold badges60 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

JimJay Over a year ago

Makes sense, but it's still not matching.. I just get a 404

coderanger Over a year ago

Ahh, and that should also be (?P<id>), thats the more important one :-)

JimJay Over a year ago

ok, that got it.. not sure what that second ? is for but thanks! :)

coderanger Over a year ago

(?P<name>...) marks a named capture, in general most special types of capture groups start with (?

Burhan Khalid · Accepted Answer · 2012-04-28 18:51:51Z

0

You are missing quotes.

urlpatterns += patterns('',
    url(r'^options/, include(options.urls')),
)

Should be

urlpatterns += patterns('',
    url(r'^options/', include('options.urls')),
)

I'm not too sure of your expression, might try this:

urlpatterns = patterns('options.views', 
    url(r'^items/(?<=-)(?P<id>\d+)/$', 'details'),
    ...
)

edited Apr 28, 2012 at 18:51

answered Apr 28, 2012 at 18:29

Burhan Khalid

175k20 gold badges255 silver badges292 bronze badges

1 Comment

okm Over a year ago

The part between / and (?P...) does not get matched hence no match for whole

Collectives™ on Stack Overflow

Django url regexp not working

2 Answers 2

4 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related