Changing onclick attribute using replace with jQuery

Question

Do someone know what is the best way to replace some string inside a onclick attribute ?
I need to get the current value and replace some text inside parameters.

Exemple,
I have this link:

<a href="#" onclick="myfunction('parameter1a','parameter1b')">My link</a>

And I want this:

<a href="#" onclick="myfunction('parameter2a','parameter2b')">My link</a>

In other words, I want something like this:

$('a').attr('onclick', $(this).attr('onclick').replace('1', '2'));

And I know I can do this, but I need something dynamic retreiving the values of current element:

$("a").attr('onClick', "myfunction('parameter2a','parameter2b')");

Finally it working when I made a simple demo: http://jsfiddle.net/GkWhh/4/

Thank you for your solutions !

You just need to know what the paramters are you need to change and create a conditional statement within the click function to pass the parameters to your custom myFunction(par1, par2) — Ohgodwhy
– Ohgodwhy, Commented Jan 16, 2013 at 19:03
Why do you need to do this in first place? How is this layout being created and why can't you change it? Overall, this is a wrong approach — Alexander
– Alexander, Commented Jan 16, 2013 at 19:11
I made a simple demo on jsFiddle. But finally it working! I will look closer to my real code to see what is missing. Before, when I added some objectives (see demo) the link to add Solution didnt update the parameters. Thank you for your help ! — Shad Gagnon
– Shad Gagnon, Commented Jan 16, 2013 at 22:02

Ram · Accepted Answer · 2013-01-16 19:19:01Z

11

$('a[onclick]').attr('onclick', function(i, v){
   return v.replace(/1/g, '2');
});

http://jsfiddle.net/cj9j7/

If you need something more dynamic do not use onclick attributes, changing onclick attributes is hackish, you can use click method instead.

var param = 1;
$('a').click(function(){
   // ...

   if ('wildguess') {
     param = 1;
   } else {
     param++;
   }
})

edited Jan 16, 2013 at 19:19

answered Jan 16, 2013 at 19:09

Ram

145k16 gold badges174 silver badges201 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

h0tw1r3 Over a year ago

I would also change the selector to a[onclick]

Shad Gagnon Over a year ago

It is weird, I see that it's working on your jsFiddle. But for me the console show me : Uncaught TypeError: Object function onclick(event) { myfunction('parameter1a','parameter1b') } has no method 'replace'

Ram Over a year ago

@ShadGagnon That's because some of your a elements don't have onclick attributes, I have updated the selector.

Shad Gagnon Over a year ago

I have updated the selector... But the problem is still here. I tried to alert the onclick attr like this alert($(this).attr('onclick')) before the return v.replace(/1/g, '2') and it show me my function correctly. The console still show : Uncaught TypeError: Object function onclick(event) { myfunction('parameter1a','parameter1b' } has no method 'replace'

Ram Over a year ago

@ShadGagnon Can you provide a demo on jsfiddle?

|

roman · Accepted Answer · 2013-01-16 19:10:03Z

1

sounds like a really bad idea but anyway - you can access the string value of the onlick attribute using something like that:

$('a').each(function() { this.attributes.onclick.nodeValue = this.attributes.onclick.nodeValue.replace('1', '2'); })

answered Jan 16, 2013 at 19:10

roman

11.3k1 gold badge33 silver badges42 bronze badges

Comments

Jai · Accepted Answer · 2013-01-16 19:11:57Z

0

You can do this: http://jsfiddle.net/SJP7k/

var atr = $('a').attr('onclick');
var str = atr.split('1');
var natr = str.join('2');
$('a').attr('onclick',natr);

answered Jan 16, 2013 at 19:11

Jai

74.8k12 gold badges77 silver badges104 bronze badges

Collectives™ on Stack Overflow

Changing onclick attribute using replace with jQuery

3 Answers 3

6 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

6 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related