Trying to replace a html attribute using a click function

Question

I'm trying to take an a element and take the information from the data-id attribute and store it into a variable. I want to then splice this variable so I get the part that I need and implement it into another variable with some text. From that I then want to replace the src attribute of an iframe with the variable. Unfortunately, this doesn't seem to be working at all and I can't find the issue.

Here is the code:

$('.watchvideo').click(function(){
    var idu = $(this).attr('data-id');
    var id = "//www.youtube.com/embed/"idu.substr(27,37);

    $('.videofeatem').setAttribute("src", id);

});

if you add a jsfiddle it would be easier to debug, but from the code it looks like you need var id = "youtube.com/embed/"+idu.substr(27,37); — user2879041
– user2879041, Commented Jan 6, 2015 at 19:00
var id = "//www.youtube.com/embed/" + idu.substr(27,37); Check if this works. Seems like you missed a +. — vjdhama
– vjdhama, Commented Jan 6, 2015 at 19:00

Milind Anantwar · Accepted Answer · 2015-01-06 19:02:25Z

3

You have 2 issues in code:

1) concatenating substring

2) setting attribute via jquery

var id = "//www.youtube.com/embed/"+idu.substr(27,37);
$('.videofeatem').attr("src", id);

answered Jan 6, 2015 at 19:02

Milind Anantwar

82.3k26 gold badges97 silver badges128 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

vjdhama Over a year ago

This answer maybe covers all the problems.

Paul Roub · Accepted Answer · 2015-01-06 19:01:14Z

2

Without seeing the HTML, it's tough to be sure, but a + fixes the obvious problem:

$('.watchvideo').click(function(){
    var idu = $(this).data('id');
    var id = "//www.youtube.com/embed/" + idu.substr(27,37);

    $('.videofeatem').attr("src", id);
 });

Also, note that data-xxx attributes can be read by jQuery as .data('xxx')

answered Jan 6, 2015 at 19:01

Paul Roub

36.5k27 gold badges88 silver badges95 bronze badges

Comments

jesusr · Accepted Answer · 2015-01-06 19:02:24Z

0

Simply.

var id = "//www.youtube.com/embed/" + idu.substr(27,37);

answered Jan 6, 2015 at 19:02

jesusr

112 bronze badges

Comments

Taylor Kolasinski · Accepted Answer · 2015-01-06 19:03:00Z

0

Since you're using jQuery, use the .attr() method instead of the .setAttribute().

answered Jan 6, 2015 at 19:03

Taylor Kolasinski

313 bronze badges

Collectives™ on Stack Overflow

Trying to replace a html attribute using a click function

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related