Error Handler Nodejs Redis Connect-domain fail

Question

I tried to use connect-domain to handling error. In most cases it ok, but it fail with redis callback. How to fix this?

Here's my app

var http = require('http');
var express = require('express');
var connectDomain = require('connect-domain');
var redis = require("redis").createClient();

var app = express();
app.use(connectDomain());

app.get('/', function (req, res) {
    throw new Error("Handler OK");
});

app.get('/error', function (req, res) {
    redis.get("akey", function(err, reply) {
        throw new Error("Handler error");
        res.end("ok");
    });
});

app.use(function (err, req, res, next) {
    res.end(err.message);
});

http.createServer(app).listen(8989, function() {
    console.log("Express server started ");
});

I use nodejs 0.8.16, all modules are latest

inspirationCloud · Accepted Answer · 2013-09-03 17:26:09Z

10

Not sure if the domain should be catching that or not - but you can capture redis errors by setting up an error handler, like this:

// handle redis connection temporarily going down without app crashing
redisClient.on("error", function(err) {
    console.error("Error connecting to redis", err);
});

While the connection is broken your handler will keep getting called as redis tries to reconnect. If it's eventually successful everything will come back online on it's own.

answered Sep 3, 2013 at 17:26

inspirationCloud

3512 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

teddy Over a year ago

My problem must be solve for production use, of course. Because this problem, I have spend a lot effort to catch exception to ensure that the system isn't terminated on production mode.

Vinod Gupta · Accepted Answer · 2014-07-28 17:04:55Z

0

You can also try https://www.npmjs.org/package/wait-for-redis. It ensures clients can wait for server to be up in case when clients start early.

answered Jul 28, 2014 at 17:04

Vinod Gupta

1

Collectives™ on Stack Overflow

Error Handler Nodejs Redis Connect-domain fail

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related