Return false from Function within function - Javascript Form Validation

Question

I made a function which validates a form and works fine but I now want to break it down into 3 separate functions.

I now have a function which is called by the form being submitted which declares some arrays and runs the three functions. When it was all one big function the various if statements that found errors would return false; which would then go back to the form and stop it sending.

However now that I've got functions within a function I can't figure out how to get that message 'false' back to the form.

Below is the function called by the form submit button followed by the main function it calls. I tried creating an empty variable which is returned instead of false which is then is assigned the value false by the validateSignup function but it didn't work.

function validateSignup()
{
 // Declaring Arrays (deleted array contents)
 var errorSpansArray=[whatever];   
 var regexErrorArray=[whatever];
 var regexArray=[whatever];

validateText(0,6,errorSpansArray, regexErrorArray, regexArray);
passMatch();
genderCountryCheck()  
}

function validateText(formNumber, numberElements, errorSpansArrayName, regexErrorArrayName, regexArrayName)
 {              
                     for (x = 0; x<numberElements; x++)
                   {
                   var spanName = errorSpansArrayName[x];
                   var textError = document.getElementById(spanName);
                   var y=document.forms[formNumber].elements[x];
                   if (!y.value)
                   {           
                    errorMessage(0,spanName,x);
                   return false;
                   }
                   if(!regexArrayName[x].test(y.value)){  
                   textError.innerHTML = regexErrorArrayName[x];
                   return false;

                   }
               }

UPDATE: Thanks for your responses. I have found a solution that seems to work for me.

 function validateSignup()
 {
 // Declaring Arrays (deleted array contents)
 var errorSpansArray=[whatever];   
 var regexErrorArray=[whatever];
 var regexArray=[whatever];

var returnValidateText=validateText(0,6,errorSpansArray, regexErrorArray, regexArray);
var returnPassMatch = passMatch();
var returnGenderCountry = genderCountryCheck();

if (returnValidateText || returnPassMatch || returnGenderCountry === false)
    {
    return false;            
    }
    else{
    return true;    
    }

}

surfmuggle · Accepted Answer · 2014-01-05 16:40:09Z

1

If you call the function it returns a value

   var formIsValid = function validateText(....)

should do the trick.

function validateSignup()
{
     // Declaring Arrays (deleted array contents)
     var errorSpansArray=[whatever];   
     var regexErrorArray=[whatever];
     var regexArray=[whatever];

     var formIsValid = false;

    formIsValid = validateText(0,6,errorSpansArray, regexErrorArray, regexArray);
    formIsValid = passMatch();
    formIsValid = genderCountryCheck()  
}

answered Jan 5, 2014 at 16:40

surfmuggle

6,0468 gold badges59 silver badges97 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

JaredPar · Accepted Answer · 2014-01-05 16:40:05Z

0

One way is to just check the individual function returns directly and return based on that

if (!validateText(0,6,errorSpansArray, regexErrorArray, regexArray)) {
  return false;
}
if (!passMatch()) {
  return false;
}    
if (!genderCountryCheck()) { 
  return false;
}

Although it's shorter to use a single conditional

return
  validateText(0,6,errorSpansArray, regexErrorArray, regexArray) &&
  passMatch() &&
  genderCountryCheck();

answered Jan 5, 2014 at 16:40

JaredPar

760k152 gold badges1.3k silver badges1.5k bronze badges

Comments

AbhinavRanjan · Accepted Answer · 2014-01-05 16:41:51Z

0

In javascript return false means false will be returned as value where the method is called. So you need something like

If(validateText()){
    return true;
}

And similarly rest of the code.

answered Jan 5, 2014 at 16:41

AbhinavRanjan

1,65617 silver badges21 bronze badges

Collectives™ on Stack Overflow

Return false from Function within function - Javascript Form Validation

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related