return false is not working in javascript validation

Question

function confirmValidation() {
    var confirmPass = document.getElementById('newpassword').value;
    var newpass = document.getElementById('newpassword2').value;
    var passLength = confirmPass.length;
    if ((confirmPass == newpass) && (confirmPass != "" && newpass != "") && (passLength > 8)) {
        alert("ok");
        return true;
    } else {
        alert("no");
        confirmPass.focus();
        return false;
    }
}

And input:

<input name="register" type="submit" class="alert_button" onclick="return confirmValidation()" value="OK" />

where are the other controls you are calling by Id in you JS — polin
– polin, Commented Mar 4, 2013 at 4:58
Why are most of the questions being downvoted off late on SO ! — Harsha Venkataramu
– Harsha Venkataramu, Commented Mar 4, 2013 at 4:59
Which browser are you using? I have heard Chrome had some issues earlier with onSubmit return. productforums.google.com/forum/#!topic/chrome/Z3MD5Od3oQM — kiranvj
– kiranvj, Commented Mar 4, 2013 at 5:40

Community · Accepted Answer · 2020-06-20 09:12:55Z

3

For the return method to work, you need to specify onSubmit attribute/listener to the form tag itself. Like so:

<form method="post" onsubmit="return confirmValidation();">
    <!-- OTHER form fields -->
</form>

From w3c documentation:

The onsubmit event occurs when a form is submitted. It only applies to the FORM element.

EDIT

jsfiddle link added.

You must alter your JavaScript a little so that .focus() may fire.

function confirmValidation() {
    var confirmPass = document.getElementById('newpassword');
    var newpass = document.getElementById('newpassword2');
    var passLength = confirmPass.value.length;
    if ((confirmPass.value == newpass.value) && (confirmPass.value != "" && newpass.value != "") && (passLength > 8)) {
        alert("ok");
        return true;
    } else {
        alert("no");
        confirmPass.focus();
        return false;
    }
}

edited Jun 20, 2020 at 9:12

CommunityBot

11 silver badge

answered Mar 4, 2013 at 4:59

hjpotter92

81.1k36 gold badges148 silver badges188 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ketan patil Over a year ago

<form id="emailvalidate" name="emailvalidate" action="xyz.php" method="post" onsubmit="confirmValidation()"> <div class="login_title">Create new password</div> <dl> <dt>New Password</dt> <dd><input name="newpassword" type="password" id="newpassword" size="40"> <div class="register_alert">over 8 characters</div></dd> <dt>Confirm</dt> <dd><input name="newpassword2" type="password" id="newpassword2" size="40"></dd> <dt></dt> <dd><input name="register" type="submit" class="alert_button" value="OK"> <div class="login_alert">Password doesn't match.</div> </dd> </dl> </form>

hjpotter92 Over a year ago

@user2122323 Edited reply. Please check.

pdoherty926 · Accepted Answer · 2013-03-04 04:57:40Z

1

Move your validation to the form.

document.getElementById('my_form').addEventListener('submit', confirmValidation, false);

answered Mar 4, 2013 at 4:57

pdoherty926

10.6k5 gold badges47 silver badges75 bronze badges

Comments

BenMorel · Accepted Answer · 2013-12-06 15:44:25Z

1

You should use onsubmit() event in tag. Now when you submit the form, it will call the function that is written on the onsubmit() event. Only in case of Onsubmit(), it checks the return value if it's true then it proceeds further otherwise not.

<form method="post" onsubmit="return confirmValidation();">

</form>

edited Dec 6, 2013 at 15:44

BenMorel

37k52 gold badges208 silver badges339 bronze badges

answered Mar 4, 2013 at 5:47

Jatin Khurana

1,1758 silver badges17 bronze badges

Collectives™ on Stack Overflow

return false is not working in javascript validation

3 Answers 3

EDIT

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

EDIT

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related